Chromecast: initial checkin of Android-based cast shell.

chromecast/chromecast.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'chromecast_branding%': 'Chromium',
   },
   'target_defaults': {
@@ skipping 24 matching lines @@
             'internal/chromecast_internal.gyp:cast_common_internal',
           ],
         }, {
           'sources': [
             'common/chromecast_config_simple.cc',
           ],
         }],
       ],
     },
     {
+      'target_name': 'cast_net',
+      'type': '<(component)',
+      'sources': [
+        'net/network_change_notifier_cast.cc',

[Yaron, 2014/08/20 18:11:02]

Why not include in the existing "net" target? Is this really just a stub and
there's no NetworkCHangeNotifier in cast?

[gunsch, 2014/08/21 22:31:28]

What do you mean by the existing "net" target? |src/net/net.gyp:net| ?

Chromium has overall expressed that they would prefer Chromecast to keep all of
our code in |src/chromecast/|, rather than scattering throughout the Chromium
codebase|. We've been explicitly disallowed a C-define such as |OS_CHROMECAST|,
so we intend to be a standalone content-embedder implementation.

This specific change in this CL separates out a |cast_net| target for ourselves,
because it is Linux-specific (for the Chromecast product) and not appropriate
when |OS=="android"|. In this case, cast_shell uses Android's
NetworkChangeNotifier.

+        'net/network_change_notifier_cast.h',
+        'net/network_change_notifier_factory_cast.cc',
+        'net/network_change_notifier_factory_cast.h',
+      ],
+    },
+    {
       'target_name': 'cast_service',
       'type': '<(component)',
       'dependencies': [
         '../skia/skia.gyp:skia',
       ],
       'sources': [
         'service/cast_service.cc',
         'service/cast_service.h',
       ],
       'conditions': [
         ['chromecast_branding=="Chrome"', {
           'dependencies': [
             'internal/chromecast_internal.gyp:cast_service_internal',
           ],
         }, {
           'dependencies': [
             '../base/base.gyp:base',
             '../content/content.gyp:content',
           ],
-          'sources': [
-            'service/cast_service_simple.cc',
-            'service/cast_service_simple.h',
+          'conditions': [
+            ['OS=="android"', {
+              'sources': [
+                'service/cast_service_android.cc',
+                'service/cast_service_android.h',
+              ],
+            }, {
+              'sources': [
+                'service/cast_service_simple.cc',
+                'service/cast_service_simple.h',
+              ],
+            }],
           ],
         }],
       ],
     },
     {
       'target_name': 'cast_shell_resources',
       'type': 'none',
       'variables': {
         'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chromecast',
       },
@@ skipping 39 matching lines @@
               '<(SHARED_INTERMEDIATE_DIR)/ui/strings/ui_strings_en-US.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/devtools_resources.pak',
               '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
             ],
             'pak_output': '<(PRODUCT_DIR)/assets/cast_shell.pak',
           },
           'includes': [ '../build/repack_action.gypi' ],
         },
       ],
     },
+    # This target contains all content-embedder implementation that is
+    # non-platform-specific.
     {
-      'target_name': 'cast_shell',
-      'type': 'executable',
+      'target_name': 'cast_shell_common',
+      'type': '<(component)',
       'dependencies': [
         'cast_common',
         'cast_service',
         'cast_shell_pak',
         'cast_shell_resources',
         'cast_version_header',
         'chromecast_locales.gyp:chromecast_locales_pak',
         'chromecast_locales.gyp:chromecast_settings',
-        '../ui/aura/aura.gyp:aura_test_support',
         '../content/content.gyp:content',
         '../content/content.gyp:content_app_browser',
         '../skia/skia.gyp:skia',
       ],
       'sources': [
-        'net/network_change_notifier_cast.cc',
-        'net/network_change_notifier_cast.h',
-        'net/network_change_notifier_factory_cast.cc',
-        'net/network_change_notifier_factory_cast.h',
-        'shell/app/cast_main.cc',
         'shell/app/cast_main_delegate.cc',
         'shell/app/cast_main_delegate.h',
         'shell/browser/cast_browser_context.cc',
         'shell/browser/cast_browser_context.h',
         'shell/browser/cast_browser_main_parts.cc',
         'shell/browser/cast_browser_main_parts.h',
         'shell/browser/cast_content_browser_client.cc',
         'shell/browser/cast_content_browser_client.h',
         'shell/browser/cast_http_user_agent_settings.cc',
         'shell/browser/cast_http_user_agent_settings.h',
         'shell/browser/devtools/cast_dev_tools_delegate.cc',
         'shell/browser/devtools/cast_dev_tools_delegate.h',
         'shell/browser/devtools/remote_debugging_server.cc',
         'shell/browser/devtools/remote_debugging_server.h',
         'shell/browser/geolocation/cast_access_token_store.cc',
         'shell/browser/geolocation/cast_access_token_store.h',
         'shell/browser/url_request_context_factory.cc',
         'shell/browser/url_request_context_factory.h',
         'shell/browser/webui/webui_cast.h',
         'shell/common/cast_content_client.cc',
         'shell/common/cast_content_client.h',
         'shell/renderer/cast_content_renderer_client.cc',
         'shell/renderer/cast_content_renderer_client.h',
       ],
       'conditions': [
         ['chromecast_branding=="Chrome"', {
           'dependencies': [
-            'internal/chromecast_internal.gyp:cast_gfx_internal',
             'internal/chromecast_internal.gyp:cast_shell_internal',
           ],
         }, {
-          'dependencies': [
-            '../ui/ozone/ozone.gyp:eglplatform_shim_x11',
-          ],
           'sources': [
             'shell/browser/devtools/remote_debugging_server_simple.cc',
             'shell/browser/webui/webui_cast_simple.cc',
           ],
         }],
       ],
     },
     {
       'target_name': 'cast_version_header',
       'type': 'none',
@@ skipping 20 matching lines @@
             'common/version.h.in',
             '<@(_outputs)',
           ],
           'includes': [
             '../build/util/version.gypi',
           ],
         },
       ],
     },
   ],  # end of targets
+
+  # Targets for Android receiver.
+  'conditions': [
+    ['OS=="android"', {
+      'targets': [
+        {
+          'target_name': 'libcast_shell_android',

[Yaron, 2014/08/20 18:11:02]

any reason this needs "android" in the name?

[gunsch, 2014/08/21 22:31:28]

Since this generates a shared library |libcast_shell_android.so| that is one of
our primary outputs, we find it helpful to distinguish from a less clearly named
|libcast_shell.so|.

But if you feel strongly, I can change to simply libcast_shell.

+          'type': 'shared_library',
+          'dependencies': [
+            'cast_common',
+            'cast_shell_common',
+            'cast_jni_headers',
+            'cast_shell_pak',
+            'cast_version_header',
+            '../base/base.gyp:base',
+            '../content/content.gyp:content_app_browser',
+            '../content/content.gyp:content',
+            '../skia/skia.gyp:skia',
+            '../ui/gfx/gfx.gyp:gfx',
+            '../ui/gl/gl.gyp:gl',
+          ],
+          'sources': [
+            'android/cast_jni_registrar.cc',
+            'android/cast_jni_registrar.h',
+            'android/chromecast_config_android.cc',
+            'android/chromecast_config_android.h',
+            'android/platform_jni_loader.h',
+            'shell/app/android/cast_jni_loader.cc',
+            'shell/browser/android/cast_window_manager.cc',
+            'shell/browser/android/cast_window_manager.h',
+            'shell/browser/android/cast_window_android.cc',
+            'shell/browser/android/cast_window_android.h',
+          ],
+          'conditions': [
+            ['chromecast_branding=="Chrome"', {
+              'dependencies': [
+                '<(cast_internal_gyp):cast_shell_android_internal'
+              ],
+            }, {
+              'sources': [
+                'android/chromecast_config_android_simple.cc',
+                'android/platform_jni_loader_simple.cc',
+              ],
+            }]
+          ],
+        },  # end of target 'libcast_shell_android'
+        {
+          'target_name': 'cast_shell_java',
+          'type': 'none',
+          'dependencies': [
+            '../base/base.gyp:base_java',
+            '../content/content.gyp:content_java',
+            '../media/media.gyp:media_java',
+            '../net/net.gyp:net_java',
+            '../third_party/android_tools/android_tools.gyp:android_support_v13_javalib',
+            '../tools/android/forwarder/forwarder.gyp:forwarder',

[Yaron, 2014/08/20 18:11:01]

Why does the java target depend on forwarder and image_diff?

[gunsch, 2014/08/21 22:31:28]

Removed.

+            '../tools/imagediff/image_diff.gyp:image_diff#host',
+            '../ui/android/ui_android.gyp:ui_java',
+          ],
+          'variables': {
+            'has_java_resources': 1,
+            'java_in_dir': 'shell/android/apk',
+            'resource_dir': 'shell/android/apk/res',
+            'R_package': 'org.chromium.chromecast.shell',
+          },
+          'includes': ['../build/java.gypi'],
+        },  # end of target 'cast_shell_java'
+        {
+          'target_name': 'cast_shell_apk',
+          'type': 'none',
+          'dependencies': [
+            'cast_shell_java',
+            'libcast_shell_android',
+          ],
+          'variables': {
+            'apk_name': 'CastShell',
+            'manifest_package_name': 'org.chromium.chromecast.shell',
+            # Note(gunsch): there are no Java files in the android/ directory.
+            # Unfortunately, the java_apk.gypi target rigidly insists on having
+            # a java_in_dir directory, but complains about duplicate classes
+            # from the common cast_shell_java target (shared with internal APK)
+            # if the actual Java path is used.

[Yaron, 2014/08/20 18:11:02]

what's the sync.stamp file for? is it part of this?

Don't you at least need an Application/Activity? Why is this empty?

[gunsch, 2014/08/21 22:31:28]

|sync.stamp|: didn't mean to check it in. We had used it locally as a way to
force rebuilds of a generated version file. Removed, thanks for catching.

I have an |Application| and |Activity|. They're specified within the
|cast_shell_java| target above. All code in that target is shared by our
internal APK target, which builds the entire "Chromecast for Android TV" APK.

The difference between the two (from our perspective) should be conceptually
similar to "ContentShell.apk vs. Chrome on Android", with the caveat that in our
case the final "Chromecast for Android TV" product includes all of the public
code.

+            # This will hopefully be removable after the great GN migration.
+            'java_in_dir': 'android',
+            'android_manifest_path': 'shell/android/apk/AndroidManifest.xml',
+            'package_name': 'org.chromium.chromecast.shell',
+            'native_lib_target': 'libcast_shell_android',
+            'asset_location': '<(PRODUCT_DIR)/assets',
+            'additional_input_paths': ['<(PRODUCT_DIR)/assets/cast_shell.pak'],
+          },
+          'includes': [ '../build/java_apk.gypi' ],
+        },
+        {
+          'target_name': 'cast_jni_headers',
+          'type': 'none',
+          'sources': [
+            'shell/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java',
+            'shell/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java',
+          ],
+          'direct_dependent_settings': {
+            'include_dirs': [
+              '<(SHARED_INTERMEDIATE_DIR)/chromecast',
+            ],
+          },
+          'variables': {
+            'jni_gen_package': 'chromecast',
+          },
+          'includes': [ '../build/jni_generator.gypi' ],
+        },
+      ],  # end of targets
+    }, {
+      'targets': [
+        # This target contains all of the primary code of |cast_shell|.
+        # This also includes all targets that cannot be built on Android.
+        {
+          'target_name': 'cast_shell',
+          'type': 'executable',
+          'dependencies': [
+            'cast_net',
+            'cast_shell_common',
+            '../ui/aura/aura.gyp:aura_test_support',
+          ],
+          'sources': [
+            'shell/app/cast_main.cc',
+          ],
+          'conditions': [
+            ['chromecast_branding=="Chrome"', {
+              'dependencies': [
+                'internal/chromecast_internal.gyp:cast_gfx_internal',
+              ],
+            }, {
+              'dependencies': [
+                '../ui/ozone/ozone.gyp:eglplatform_shim_x11',
+              ],
+            }],
+          ],
+        },
+      ],  # end of targets
+    }],
+  ],  # end of conditions
 }