chromecast/android/platform_jni_loader_simple.cc - Issue 490603002: Chromecast: initial checkin of Android-based cast shell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/android/platform_jni_loader_simple.cc

Issue 490603002: Chromecast: initial checkin of Android-based cast shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chromecast/common/chromecast_config.h"	5 #include "chromecast/android/platform_jni_loader.h"

6	6

7 namespace chromecast {	7 namespace chromecast {

	8 namespace android {

8	9

9 void ChromecastConfig::RegisterPlatformPrefs(PrefRegistrySimple* registry) {	10 void PlatformRegisterJni(JNIEnv* env) {
	Yaron 2014/08/20 18:11:01 Again, not super excited about these stubs. Will t Again, not super excited about these stubs. Will these be used? Do you have more details about upstreaming plan somewher? gunsch 2014/08/21 22:31:28 I don't think we have a doc for public consumption Show quoted text On 2014/08/20 18:11:01, Yaron wrote: > Again, not super excited about these stubs. Will these be used? Do you have more > details about upstreaming plan somewher? I don't think we have a doc for public consumption. Le-Chun Wu (lcwu@) said that he spoke with you about our high-level upstreaming plans a few months ago. Our high-level plan is to upstream as much as possible, minus several pieces that we're not ready or able to make public (our home screen UIs, partner code, etc.). To continue compiling publicly, yes, we do have these stubs, and the convention is to put them in their own file and methods named with "Platform" as the differentiating keywords. In terms of code organization, most of our private code is in an internal git repo that gets mapped to \|src/chromecast/internal/\|. The functionality change occurs largely by stubbing out a handful of methods in the public code (so that one can build a working cast_shell from upstream chromium), but that get swapped out with private implementations when building with the GYP flag \|chromecast_branding=="Chrome"\|.
10 }	11 }

11	12

	13 } // namespace android

12 } // namespace chromecast	14 } // namespace chromecast

OLD	NEW

« chromecast/android/chromecast_config_android_simple.cc ('K') | « chromecast/android/platform_jni_loader.h ('k') | chromecast/android/src/dummy » ('j') | chromecast/chromecast.gyp » ('J')