Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 490533002: Use LookupIterator to transition to accessors (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use LookupIterator to transition to accessors BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23210

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -213 lines) Patch
M src/lookup.h View 4 chunks +14 lines, -3 lines 0 comments Download
M src/lookup.cc View 1 5 chunks +67 lines, -19 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -16 lines 0 comments Download
M src/objects.cc View 4 chunks +108 lines, -151 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/v8natives.js View 1 chunk +12 lines, -2 lines 0 comments Download
A + test/mjsunit/deopt-global-accessor.js View 1 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-19 15:04:57 UTC) #1
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-08-19 16:28:01 UTC) #2
Jakob Kummerow
Still LGTM.
6 years, 4 months ago (2014-08-19 17:01:07 UTC) #3
Toon Verwaest
6 years, 4 months ago (2014-08-19 17:02:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698