Issue 490523004: [Mac] Do not show the 'Make X the default browser' button on Canary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 490523004: [Mac] Do not show the 'Make X the default browser' button on Canary. (Closed)

Created:
6 years, 4 months ago by Robert Sesek

Modified:
6 years, 4 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Mac] Do not show the 'Make X the default browser' button on Canary. For reasons that appear largely historical, the code path for determining the default-allowing state in the settings UI is special-cased on Mac. This removes that and just uses the cross-platform logic, which doesn't enable the button for Canary. BUG=370548 TEST=Put KSChannelID=canary in the Info.plist (or just run Canary) and chrome://settings button for the default browser is not present. R=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290642

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -21 lines)			Patch
	M	chrome/browser/ui/webui/options/browser_options_handler.cc	View		3 chunks	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/490523004/1

6 years, 4 months ago (2014-08-19 18:59:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290642

Expand Messages | Collapse Messages