Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 490483002: Refactor Scheduler to simplify construction of CFG from sea of nodes. Use PreEdge/Post as part of t… (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactor Scheduler to simplify construction of CFG from sea of nodes. Use PreEdge/Post as part of the graph tarversal, and make finding of successor projections more robust. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23217

Patch Set 1 #

Total comments: 1

Patch Set 2 : unmacrofy TRACE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -335 lines) Patch
M src/compiler/scheduler.h View 3 chunks +6 lines, -18 lines 0 comments Download
M src/compiler/scheduler.cc View 1 28 chunks +238 lines, -317 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
PTAL
6 years, 4 months ago (2014-08-19 14:07:34 UTC) #1
Jarin
https://codereview.chromium.org/490483002/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/490483002/diff/1/src/compiler/scheduler.cc#newcode20 src/compiler/scheduler.cc:20: if (FLAG_trace_turbo_scheduler) PrintF x Please, do not use this ...
6 years, 4 months ago (2014-08-19 14:37:28 UTC) #2
titzer
On 2014/08/19 14:37:28, jarin wrote: > https://codereview.chromium.org/490483002/diff/1/src/compiler/scheduler.cc > File src/compiler/scheduler.cc (right): > > https://codereview.chromium.org/490483002/diff/1/src/compiler/scheduler.cc#newcode20 > ...
6 years, 4 months ago (2014-08-19 15:17:23 UTC) #3
Jarin
lgtm. Thanks!
6 years, 4 months ago (2014-08-19 19:01:55 UTC) #4
titzer
6 years, 4 months ago (2014-08-20 08:57:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 23217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698