Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: ui/aura/test/ui_controls_factory_aurax11.cc

Issue 490443002: Add test for ChromeVox keyboard commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Real fix that works Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/test/ui_controls_factory_aurax11.cc
diff --git a/ui/aura/test/ui_controls_factory_aurax11.cc b/ui/aura/test/ui_controls_factory_aurax11.cc
index 59db324ac02b08f5b59123bed4f6e27c9548e97d..383d0734049e3773f959490fe08c6dd073ea7f37 100644
--- a/ui/aura/test/ui_controls_factory_aurax11.cc
+++ b/ui/aura/test/ui_controls_factory_aurax11.cc
@@ -76,7 +76,7 @@ class UIControlsX11 : public UIControlsAura {
if (alt)
SetKeycodeAndSendThenMask(&xevent, XK_Alt_L, Mod1Mask);
if (command)
- SetKeycodeAndSendThenMask(&xevent, XK_Meta_L, Mod4Mask);
+ SetKeycodeAndSendThenMask(&xevent, XK_Super_L, Mod4Mask);
xevent.xkey.keycode =
XKeysymToKeycode(gfx::GetXDisplay(),
ui::XKeysymForWindowsKeyCode(key, shift));
@@ -92,7 +92,7 @@ class UIControlsX11 : public UIControlsAura {
if (control)
UnmaskAndSetKeycodeThenSend(&xevent, ControlMask, XK_Control_L);
if (command)
- UnmaskAndSetKeycodeThenSend(&xevent, Mod4Mask, XK_Meta_L);
+ UnmaskAndSetKeycodeThenSend(&xevent, Mod4Mask, XK_Super_L);
David Tseng 2014/09/19 22:37:05 Could you explain this change? meta vs super_l and
dmazzoni 2014/09/22 06:04:04 You're right, they both work - I reverted the chan
DCHECK(!xevent.xkey.state);
RunClosureAfterAllPendingUIEvents(closure);
return true;
« no previous file with comments | « chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc ('k') | ui/aura/test/ui_controls_factory_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698