Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 49043010: Plumb device scale adjustment separately. (Closed)

Created:
7 years, 1 month ago by skobes
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rmquirk
Visibility:
Public.

Description

Plumb device scale adjustment separately. This value was previously computed into the font scale factor. BUG=252828 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232248

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M android_webview/native/aw_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
skobes
pdr - primary reviewer jamesr - for content/renderer and webkit/common boliu - for android_webview avi ...
7 years, 1 month ago (2013-10-30 18:00:26 UTC) #1
skobes
(This depends on https://codereview.chromium.org/49913005/ to land and roll into Chromium.)
7 years, 1 month ago (2013-10-30 18:01:06 UTC) #2
Avi (use Gerrit)
On 2013/10/30 18:00:26, skobes wrote: > pdr - primary reviewer > jamesr - for content/renderer ...
7 years, 1 month ago (2013-10-30 18:02:14 UTC) #3
pdr.
On 2013/10/30 18:01:06, skobes wrote: > (This depends on https://codereview.chromium.org/49913005/ to land and roll into ...
7 years, 1 month ago (2013-10-30 18:03:15 UTC) #4
jamesr
lgtm
7 years, 1 month ago (2013-10-30 18:47:32 UTC) #5
boliu
lgtm
7 years, 1 month ago (2013-10-30 18:50:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/49043010/30001
7 years, 1 month ago (2013-10-31 17:09:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=216771
7 years, 1 month ago (2013-10-31 20:31:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/49043010/30001
7 years, 1 month ago (2013-10-31 21:11:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/49043010/30001
7 years, 1 month ago (2013-10-31 23:29:24 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 00:37:07 UTC) #11
Message was sent while issue was closed.
Change committed as 232248

Powered by Google App Engine
This is Rietveld 408576698