Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: tools/test.dart

Issue 49043003: Run all tests inside an iframe + restrict number of chrome browser processes on mac (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index cefda9fd521f641674a60c402b5e85fbf1fe4c08..05566625fc61e3e22f1abb368fc8811da8903548 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -26,6 +26,7 @@ library test;
import "dart:async";
import "dart:io";
+import "dart:math" as math;
import "testing/dart/browser_controller.dart";
import "testing/dart/http_server.dart";
import "testing/dart/test_options.dart";
@@ -169,6 +170,11 @@ void testConfigurations(List<Map> configurations) {
// Safari does not allow us to run from a fresh profile, so we can only
// use one browser.
maxBrowserProcesses = 1;
+ } else if (conf['runtime'] == 'chrome' &&
+ conf['use_browser_controller'] &&
+ Platform.operatingSystem == 'macos') {
+ // Chrome on mac results in random timeouts.
+ maxBrowserProcesses = math.max(1, maxBrowserProcesses ~/ 2);
}
for (String key in selectors.keys) {
« no previous file with comments | « no previous file | tools/testing/dart/browser_controller.dart » ('j') | tools/testing/dart/browser_controller.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698