Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 490403002: Revert of Create a new AccountTrackerService (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, yoshiki+watch_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Create a new AccountTrackerService (patchset #8 of https://codereview.chromium.org/425823002/) Reason for revert: Likely causing chrome.browser.signin.OAuth2TokenServiceIntegrationTest failures on Android. TBR=rogerta@chromium.org NOTREECHECKS=true NOTRY=true Original issue's description: > Create a new AccountTrackerService PKS based on the existing AccountTracker. > > This CL is one part of the effort to change chrome to use gaiaid instead of > email address as the unique id for an account. > > BUG=341408 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291263 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1163 lines) Patch
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/signin/account_tracker_service_factory.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/signin/account_tracker_service_factory.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D components/signin/core/browser/account_tracker_service.h View 1 chunk +0 lines, -117 lines 0 comments Download
D components/signin/core/browser/account_tracker_service.cc View 1 chunk +0 lines, -431 lines 0 comments Download
D components/signin/core/browser/account_tracker_service_unittest.cc View 1 chunk +0 lines, -509 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
Created Revert of Create a new AccountTrackerService
6 years, 4 months ago (2014-08-22 05:30:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/490403002/1
6 years, 4 months ago (2014-08-22 05:31:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:31:48 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-22 05:31:50 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-22 05:33:57 UTC) #5
jabdelmalek
The CQ bit was unchecked by jabdelmalek@google.com
6 years, 4 months ago (2014-08-22 05:34:09 UTC) #6
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 4 months ago (2014-08-22 05:34:10 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-22 05:35:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/490403002/1
6 years, 4 months ago (2014-08-22 05:36:32 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 05:38:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291335

Powered by Google App Engine
This is Rietveld 408576698