Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 490373002: Add back organization field for autofill settings. (Closed)

Created:
6 years, 4 months ago by please use gerrit instead
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add back organization field for autofill settings. BUG=402207 Committed: https://crrev.com/a4da60be1f888567e523ef389c51c4556f600999 Cr-Commit-Position: refs/heads/master@{#291599}

Patch Set 1 #

Patch Set 2 : Git migration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -41 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/ios/grit_whitelist.txt View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/address_input_strings.grdp View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/address_i18n.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/address_i18n_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 7 chunks +41 lines, -37 lines 0 comments Download
M third_party/libaddressinput/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/addressinput_util.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
please use gerrit instead
Evan: PTAL Patch Set 1.
6 years, 4 months ago (2014-08-22 21:59:59 UTC) #1
Evan Stade
lgtm
6 years, 4 months ago (2014-08-22 22:35:22 UTC) #2
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 4 months ago (2014-08-22 23:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/490373002/60001
6 years, 4 months ago (2014-08-22 23:33:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-23 19:49:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -p1; error: patch failed: ...
6 years, 4 months ago (2014-08-23 19:49:14 UTC) #6
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 4 months ago (2014-08-23 20:13:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/490373002/80001
6 years, 4 months ago (2014-08-23 20:14:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (80001) as 4afbc76f2a0bb10a67d44ac3e95837e9d7cf2743
6 years, 4 months ago (2014-08-23 22:01:42 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:31:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4da60be1f888567e523ef389c51c4556f600999
Cr-Commit-Position: refs/heads/master@{#291599}

Powered by Google App Engine
This is Rietveld 408576698