[Profiles] Update legacy default profile names.

[Profiles] Update legacy default profile names.

In the new profile management world, you can find yourself using a super old 
profile named by default "Default Profile". These names should be migrated to
the new style default names ("Person 1").

The code is fantastically special because the ProfileInfoCache re-sorts itself after
each rename, so doing a batch rename is really not a thing it wants to do.

BUG=406409
Committed: https://crrev.com/be073e56a7e5941794ab268a599f3d685cfbfb86
Cr-Commit-Position: refs/heads/master@{#291598}

[noms (inactive), 2014-08-22 15:06:36]

Hiya,

I tried to do a batch rename of legacy profile names in the ProfileInfoCache
(because no one wants to look at an avatar button that says "First user"). It
was a memorable experience. Please take a look. :)

[Roger Tawa OOO till Jul 10th, 2014-08-22 15:28:04]

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_info_cache.cc (right):

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
chrome/browser/profiles/profile_info_cache.cc:1074: #endif
reverse condition and put #ifdef around all the code.

[Roger Tawa OOO till Jul 10th, 2014-08-22 15:28:26]

lgtm

[rpetterson, 2014-08-22 20:36:10]

LGTM

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_info_cache_unittest.cc (right):

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
chrome/browser/profiles/profile_info_cache_unittest.cc:612: EXPECT_EQ(4U,
GetCache()->GetNumberOfProfiles());
You could also add a fifth person whose name is "Person 2" to test that you
actually get "Person 1" and "Person 3" if there's already someone with the new
naming scheme in there. Not sure if that is tested elsewhere.

[noms (inactive), 2014-08-22 20:44:35]

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_info_cache.cc (right):

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
chrome/browser/profiles/profile_info_cache.cc:1074: #endif
On 2014/08/22 15:28:04, Roger Tawa wrote:
> reverse condition and put #ifdef around all the code.

Done.

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_info_cache_unittest.cc (right):

https://codereview.chromium.org/490363002/diff/60001/chrome/browser/profiles/...
chrome/browser/profiles/profile_info_cache_unittest.cc:612: EXPECT_EQ(4U,
GetCache()->GetNumberOfProfiles());
On 2014/08/22 20:36:10, rpetterson wrote:
> You could also add a fifth person whose name is "Person 2" to test that you
> actually get "Person 1" and "Person 3" if there's already someone with the new
> naming scheme in there. Not sure if that is tested elsewhere.

Oh, that's a great idea. Thanks!

[noms (inactive), 2014-08-23 19:07:32]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-08-23 19:08:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/490363002/80001

[commit-bot: I haz the power, 2014-08-23 22:01:11]

Committed patchset #2 (80001) as 97f33c85c597b5530e3f54f911218a0a158261fb

[commit-bot: I haz the power, 2014-09-10 02:31:42]

Patchset 2 (id:??) landed as
https://crrev.com/be073e56a7e5941794ab268a599f3d685cfbfb86
Cr-Commit-Position: refs/heads/master@{#291598}