Subzero: Fix address mode optimization involving phi temporaries.

src/IceCfgNode.cpp

Index: src/IceCfgNode.cpp
diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp
index 696a2f0b87ad9fb948535f3ded3d0ece2a0ccfe2..cd82e87d56b5ff23acaf84dfa36bbd3e5c4dfd11 100644
--- a/src/IceCfgNode.cpp
+++ b/src/IceCfgNode.cpp
@@ -167,6 +167,7 @@ void CfgNode::placePhiStores() {
       }
       Insts.insert(InsertionPoint, NewInst);
       NewInst->updateVars(this);
+      Dest->resetDefinition();

[jvoung (off chromium), 2014/08/27 16:21:07]

This is a way to indicate that the Dest variable is now multi-block?

[Jim Stichnoth, 2014/08/27 20:23:14]

It's more about indicating Dest is multi-def, to prevent address mode
optimization from following definitions across phis.

With that said, I think it's probably better to make this more automatic inside
setDefinition(), so I reverted this resetDefinition() function.

     }
   }
 }