content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 490333002: Only set accessibility focus on page load for browser tabs, not web views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 490333002: Only set accessibility focus on page load for browser tabs, not web views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index 6f4723369ce1bc00f9f45a8435c8beebc875c66f..6cda378e178199020cfefe25f5bb410d9e928793 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -370,8 +370,10 @@ public class BrowserAccessibilityManager {

private void handlePageLoaded(int id) {

if (mUserHasTouchExplored) return;

- mAccessibilityFocusId = id;

- sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);

+ if (mContentViewCore.shouldSetAccessibilityFocusOnPageLoad()) {

+ mAccessibilityFocusId = id;

Ted C 2014/08/21 20:18:58 +2 indent for these two lines

dmazzoni 2014/08/25 17:06:40 Done.

+ sendAccessibilityEvent(id, AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);

+ }

}

@CalledByNative