Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 490333002: Only set accessibility focus on page load for browser tabs, not web views. (Closed)

Created:
6 years, 4 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
Ted C, hush (inactive)
CC:
chromium-reviews, David Trainor- moved to gerrit, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, avayvod+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, benm (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only set accessibility focus on page load for browser tabs, not web views. BUG=406053 Committed: https://crrev.com/61c6121a6cb9dc16f9786830655049d68dcde67c Cr-Commit-Position: refs/heads/master@{#291713}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 chunks +23 lines, -0 lines 1 comment Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
6 years, 4 months ago (2014-08-21 19:55:00 UTC) #1
Ted C
lgtm https://codereview.chromium.org/490333002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/490333002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode304 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:304: private boolean mShouldSetAccessibilityFocusOnPageLoad = false; = false isn't ...
6 years, 4 months ago (2014-08-21 20:18:58 UTC) #2
dmazzoni
https://codereview.chromium.org/490333002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/490333002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode304 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:304: private boolean mShouldSetAccessibilityFocusOnPageLoad = false; On 2014/08/21 20:18:57, Ted ...
6 years, 3 months ago (2014-08-25 17:06:41 UTC) #3
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 3 months ago (2014-08-25 17:06:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/490333002/20001
6 years, 3 months ago (2014-08-25 17:07:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as 3c07be0fab4a728a766e1d13d7ff779b074f680d
6 years, 3 months ago (2014-08-25 18:03:18 UTC) #6
hush (inactive)
hush@chromium.org changed reviewers: + hush@chromium.org
6 years, 3 months ago (2014-08-27 18:35:38 UTC) #7
hush (inactive)
https://codereview.chromium.org/490333002/diff/20001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/490333002/diff/20001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode2909 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2909: * Return whether or not we should set accessibility ...
6 years, 3 months ago (2014-08-27 18:35:38 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:39 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/61c6121a6cb9dc16f9786830655049d68dcde67c
Cr-Commit-Position: refs/heads/master@{#291713}

Powered by Google App Engine
This is Rietveld 408576698