Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 490293003: Fix <webview> context menu positioning on mac. (Closed)

Created:
6 years, 4 months ago by lazyboy
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Fix <webview> context menu positioning on mac. Something changed along the way and it seems the coordinate translation is necessary for mac too. BUG=406117 Test=Open a <webview> in a chrome app. Right click on the <webview>, context menu should appear in correct position, regardless of the position of the <webview> relative to the embedder. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M content/browser/web_contents/web_contents_view_guest.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lazyboy
FYI, I didn't do any investigation why this is happening since I found the quick ...
6 years, 4 months ago (2014-08-21 23:51:28 UTC) #1
sky
+avi in case he knows.
6 years, 4 months ago (2014-08-22 00:07:22 UTC) #2
Avi (use Gerrit)
On 2014/08/22 00:07:22, sky wrote: > +avi in case he knows. No clue. If this ...
6 years, 4 months ago (2014-08-22 00:20:10 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-08-22 15:54:49 UTC) #4
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 4 months ago (2014-08-22 16:15:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/490293003/1
6 years, 4 months ago (2014-08-22 16:16:18 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 17:12:50 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 17:20:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 291438

Powered by Google App Engine
This is Rietveld 408576698