Implement SkPicture::bytesUsed() for SkRecord backend

src/core/SkRecord.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkRecord_DEFINED
 #define SkRecord_DEFINED
 
@@ skipping 95 matching lines @@
     T* replace(unsigned i, const SkRecords::Adopted<Existing>& proofOfAdoption) {
         SkASSERT(i < this->count());
 
         SkASSERT(Existing::kType == fTypes[i]);
         SkASSERT(proofOfAdoption == fRecords[i].ptr<Existing>());
 
         fTypes[i] = T::kType;
         return fRecords[i].set(this->allocCommand<T>());
     }
 
+    // Does not return the bytes in any pointers embedded in the Records; callers
+    // need to iterate with a visitor to measure those they care for.
+    size_t bytesUsed() const { return fAlloc.approxBytesAllocated() +
+                                      fReserved * (sizeof(Record) + sizeof(Type8)) +
+                                      sizeof(SkRecord); }
+
 private:
     // Implementation notes!
     //
     // Logically an SkRecord is structured as an array of pointers into a big chunk of memory where
     // records representing each canvas draw call are stored:
     //
     // fRecords:  [*][*][*]...
     //             |  |  |
     //             |  |  |
     //             |  |  +---------------------------------------+
@@ skipping 100 matching lines @@
     // support efficient random access and forward iteration.  (They don't need to be contiguous.)
 
     SkVarAlloc fAlloc;
     SkAutoTMalloc<Record> fRecords;
     SkAutoTMalloc<Type8> fTypes;
     // fCount and fReserved measure both fRecords and fTypes, which always grow in lock step.
     unsigned fCount;
     unsigned fReserved;
 };
 
-#endif//SkRecord_DEFINED
+#endif //SkRecord_DEFINED

[mtklein, 2014/11/18 21:38:32]

oh snap

[tomhudson, 2014/11/18 21:49:37]

Sigh, I guess there is no standard spec here? SkCanvas doesn't even have a
#endif // comment.

Undone.

[mtklein, 2014/11/18 21:54:35]

Goodness, why would we ever have a standard spec for this?!  Of course this
doesn't matter.  I tease.

But, my way is slightly most awesome.  '#ifndef ' '#define ' and '#undef//' are
all exactly 8 characters, so it feels good to see it all line up as you write
the first few lines of a new header file.