VaapiVideoAccelerator: make Vaapi accelerator work with ozone

content/common/gpu/media/vaapi_drm_picture.cc

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/gpu/media/va_surface.h"
+#include "content/common/gpu/media/vaapi_drm_picture.h"
+#include "content/common/gpu/media/vaapi_wrapper.h"
+#include "third_party/libva/va/drm/va_drm.h"
+#include "third_party/libva/va/va_drmcommon.h"
+#include "ui/gl/gl_bindings.h"
+#include "ui/gl/gl_image.h"
+#include "ui/gl/gl_image_egl.h"
+#include "ui/gl/scoped_binders.h"
+#include "ui/ozone/public/native_pixmap.h"
+#include "ui/ozone/public/ozone_platform.h"
+#include "ui/ozone/public/surface_factory_ozone.h"
+
+namespace content {
+
+VaapiDrmPicture::VaapiDrmPicture(
+    base::WeakPtr<VaapiWrapper> vaapi_wrapper,
+    const base::Callback<bool(void)> make_context_current,
+    int32 picture_buffer_id,
+    uint32 texture_id,
+    const gfx::Size& size)
+    : VaapiPicture(picture_buffer_id, texture_id, size),
+      vaapi_wrapper_(vaapi_wrapper),
+      make_context_current_(make_context_current) {
+}
+
+VaapiDrmPicture::~VaapiDrmPicture() {
+  // At this point |vaapi_wrapper_| shouldn't be available anymore.
+  DCHECK(!vaapi_wrapper_.get());
+
+  if (egl_image_.get() && make_context_current_.Run()) {
+    // ReleaseTexImage on a GLImageEGL does nothing, to deassociate
+    // the renderer's texture from the image, just set the storage
+    // of that texture to NULL.
+    gfx::ScopedTextureBinder texture_binder(GL_TEXTURE_2D, texture_id());
+    glTexImage2D(GL_TEXTURE_2D,
+                 0,
+                 GL_RGBA,
+                 size().width(),
+                 size().height(),
+                 0,
+                 GL_RGBA,
+                 GL_UNSIGNED_BYTE,
+                 NULL);
+
+    egl_image_->Destroy(true);
+
+    DCHECK_EQ(glGetError(), GL_NO_ERROR);
+  }
+}
+
+bool VaapiDrmPicture::Initialize() {
+  VASurfaceAttrib va_attribs[2];
+  VASurfaceAttribExternalBuffers va_attrib_extbuf;
+
+  ui::OzonePlatform* platform = ui::OzonePlatform::GetInstance();
+  ui::SurfaceFactoryOzone* factory = platform->GetSurfaceFactoryOzone();
+
+  pixmap_ =
+      factory->CreateNativePixmap(size(), ui::SurfaceFactoryOzone::RGBA_8888);
+  if (!pixmap_.get()) {
+    LOG(ERROR) << "Failed creating an Ozone NativePixmap";
+    return false;
+  }
+
+  int dmabuf_fd = pixmap_->GetDmaBufFd();
+  if (dmabuf_fd < 0) {
+    LOG(ERROR) << "Failed get dmabuf from an Ozone NativePixmap";
+    return false;
+  }
+
+  va_attrib_extbuf.pixel_format = VA_FOURCC_BGRX;
+  va_attrib_extbuf.width = size().width();
+  va_attrib_extbuf.height = size().height();
+  va_attrib_extbuf.data_size = size().height() * pixmap_->GetDmaBufPitch();
+  va_attrib_extbuf.num_planes = 1;
+  va_attrib_extbuf.pitches[0] = pixmap_->GetDmaBufPitch();
+  va_attrib_extbuf.offsets[0] = 0;
+  va_attrib_extbuf.buffers = reinterpret_cast<unsigned long*>(&dmabuf_fd);
+  va_attrib_extbuf.num_buffers = 1;
+  va_attrib_extbuf.flags = 0;
+  va_attrib_extbuf.private_data = NULL;
+
+  va_attribs[0].type = VASurfaceAttribMemoryType;
+  va_attribs[0].flags = VA_SURFACE_ATTRIB_SETTABLE;
+  va_attribs[0].value.type = VAGenericValueTypeInteger;
+  va_attribs[0].value.value.i = VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME;
+
+  va_attribs[1].type = VASurfaceAttribExternalBufferDescriptor;
+  va_attribs[1].flags = VA_SURFACE_ATTRIB_SETTABLE;
+  va_attribs[1].value.type = VAGenericValueTypePointer;
+  va_attribs[1].value.value.p = &va_attrib_extbuf;
+
+  va_surface_ = vaapi_wrapper_->CreateUnownedSurface(
+      VA_RT_FORMAT_RGB32, size(), va_attribs, arraysize(va_attribs));
+  if (!va_surface_.get()) {
+    LOG(ERROR) << "Failed to create VASurface for an Ozone NativePixmap";
+    return false;
+  }
+
+  if (!make_context_current_.Run())
+    return false;
+
+  egl_image_ = new gfx::GLImageEGL(size());
+  EGLint attrs[] = {EGL_IMAGE_PRESERVED_KHR, EGL_TRUE, EGL_NONE};
+  if (!egl_image_->Initialize(
+          EGL_NATIVE_PIXMAP_KHR, pixmap_->GetEGLClientBuffer(), attrs)) {

[alexst (slow to review), 2014/11/05 20:58:25]

Driveby: pixmap_ will have either a dmabuf or a client buffer, not both. Right
now the gbm platform is returning a dmabuf as used above.

You can use gfx::GLImageLinuxDMABuffer here instead of gfx::GLImageEGL to make
it work.

[llandwerlin-old, 2014/11/10 09:34:16]

Done.

+    LOG(ERROR) << "Failed to create an EGLImage for an Ozone NativePixmap";
+    return false;
+  }
+
+  gfx::ScopedTextureBinder texture_binder(GL_TEXTURE_2D, texture_id());
+  if (!egl_image_->BindTexImage(GL_TEXTURE_2D)) {
+    LOG(ERROR) << "Failed to bind texture to EGLImage";
+    return false;
+  }
+
+  return true;
+}
+
+bool VaapiDrmPicture::DownloadFromSurface(
+    const scoped_refptr<VASurface>& va_surface) {
+  return vaapi_wrapper_->BlitSurface(va_surface->id(),
+                                     va_surface->size(),
+                                     va_surface_->id(),
+                                     va_surface_->size());
+}
+
+void VaapiDrmPicture::DisposeVaapi() {
+  va_surface_ = NULL;
+}
+
+}  // namespace