VaapiVideoAccelerator: make Vaapi accelerator work with ozone

content/common/gpu/media/vaapi_h264_decoder_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 // This has to be included first.
 // See http://code.google.com/p/googletest/issues/detail?id=371
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 63 matching lines @@
   // Give all surfaces in available_surfaces_ to the decoder.
   void RefillSurfaces();
 
   // Free the current set of surfaces and allocate a new set of
   // surfaces. Returns true when successful.
   bool AllocateNewSurfaces();
 
   // Use the data in the frame: write to file and update MD5 sum.
   bool ProcessVideoFrame(const scoped_refptr<media::VideoFrame>& frame);
 
-  scoped_ptr<VaapiWrapper> wrapper_;
+  scoped_refptr<VaapiWrapper> wrapper_;
   scoped_ptr<VaapiH264Decoder> decoder_;
   std::string data_;            // data read from input_file
   base::FilePath output_file_;  // output data is written to this file
   std::vector<VASurfaceID> available_surfaces_;
 
   // These members (x_display_, num_outputted_pictures_, num_surfaces_)

[Pawel Osciak, 2014/11/03 01:36:51]

No x_display_ anymore.

[llandwerlin-old, 2014/11/03 09:30:11]

Acknowledged.

   // need to be initialized and possibly freed manually.
-  Display* x_display_;
   int num_outputted_pictures_;  // number of pictures already outputted
   size_t num_surfaces_;  // number of surfaces in the current set of surfaces
   base::MD5Context md5_context_;
 };
 
 VaapiH264DecoderLoop::VaapiH264DecoderLoop()
-    : x_display_(NULL), num_outputted_pictures_(0), num_surfaces_(0) {
+    : num_outputted_pictures_(0), num_surfaces_(0) {
   base::MD5Init(&md5_context_);
 }
 
 VaapiH264DecoderLoop::~VaapiH264DecoderLoop() {
   // We need to destruct decoder and wrapper first because:
   // (1) The decoder has a reference to the wrapper.
   // (2) The wrapper has a reference to x_display_.

[Pawel Osciak, 2014/11/03 01:36:51]

No x_display_ anymore.

[llandwerlin-old, 2014/11/03 09:30:10]

Acknowledged.

   decoder_.reset();
-  wrapper_.reset();
-
-  if (x_display_) {
-    XCloseDisplay(x_display_);
-  }
+  wrapper_ = NULL;

[Pawel Osciak, 2014/11/03 01:36:51]

I don't think we actually need these now that you don't have XCloseDisplay and
the order of definition is correct (please add a comment).

[llandwerlin-old, 2014/11/03 09:30:11]

Acknowledged.

 }
 
 void LogOnError(VaapiH264Decoder::VAVDAH264DecoderFailure error) {
   LOG(FATAL) << "Oh noes! Decoder failed: " << error;
 }
 
 bool VaapiH264DecoderLoop::Initialize(base::FilePath input_file,
                                       base::FilePath output_file) {
-  x_display_ = XOpenDisplay(NULL);
-  if (!x_display_) {
-    LOG(ERROR) << "Can't open X display";
-    return false;
-  }
-
   media::VideoCodecProfile profile = media::H264PROFILE_BASELINE;
   base::Closure report_error_cb =
       base::Bind(&LogOnError, VaapiH264Decoder::VAAPI_ERROR);
-  wrapper_ = VaapiWrapper::Create(
-      VaapiWrapper::kDecode, profile, x_display_, report_error_cb);
+  wrapper_ =
+      VaapiWrapper::Create(VaapiWrapper::kDecode, profile, report_error_cb);
   if (!wrapper_.get()) {
     LOG(ERROR) << "Can't create vaapi wrapper";
     return false;
   }
 
   decoder_.reset(new VaapiH264Decoder(
       wrapper_.get(),
       base::Bind(&VaapiH264DecoderLoop::OutputPicture, base::Unretained(this)),
       base::Bind(&LogOnError)));
 
@@ skipping 147 matching lines @@
 }
 
 void VaapiH264DecoderLoop::RecycleSurface(VASurfaceID va_surface_id) {
   available_surfaces_.push_back(va_surface_id);
 }
 
 void VaapiH264DecoderLoop::RefillSurfaces() {
   for (size_t i = 0; i < available_surfaces_.size(); i++) {
     VASurface::ReleaseCB release_cb = base::Bind(
         &VaapiH264DecoderLoop::RecycleSurface, base::Unretained(this));
-    scoped_refptr<VASurface> surface(
-        new VASurface(available_surfaces_[i], release_cb));
+    scoped_refptr<VASurface> surface(new VASurface(
+        available_surfaces_[i], decoder_->GetPicSize(), release_cb));
     decoder_->ReuseSurface(surface);
   }
   available_surfaces_.clear();
 }
 
 bool VaapiH264DecoderLoop::AllocateNewSurfaces() {
   CHECK_EQ(num_surfaces_, available_surfaces_.size())
       << "not all surfaces are returned";
 
   available_surfaces_.clear();
@@ skipping 65 matching lines @@
       content::g_md5sum = it->second;
       continue;
     }
     if (it->first == "v" || it->first == "vmodule")
       continue;
     LOG(FATAL) << "Unexpected switch: " << it->first << ":" << it->second;
   }
 
   return RUN_ALL_TESTS();
 }