src/scopes.cc - Issue 490173002: Take ast node id counting away from Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopes.cc

Issue 490173002: Take ast node id counting away from Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Copy AstNode::IdGen over another? Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scopes.cc

diff --git a/src/scopes.cc b/src/scopes.cc

index e810d98800dd060a9661e2d3b419a2c03a591712..5a9169547e4fedfec3bf2cc3c07f21cc8a6da5a3 100644

--- a/src/scopes.cc

+++ b/src/scopes.cc

@@ -267,9 +267,8 @@ bool Scope::Analyze(CompilationInfo* info) {

// Allocate the variables.

{

- // Passing NULL as AstValueFactory is ok, because AllocateVariables doesn't

- // need to create new strings or values.

- AstNodeFactory<AstNullVisitor> ast_node_factory(info->zone(), NULL);

+ AstNodeFactory<AstNullVisitor> ast_node_factory(

+ info->zone(), info->ast_value_factory(), info->ast_node_id_gen());

if (!top->AllocateVariables(info, &ast_node_factory)) return false;

}

« src/parser.cc ('K') | « src/rewriter.cc ('k') | src/zone.h » ('j') | no next file with comments »