test/cctest/test-ast.cc - Issue 490173002: Take ast node id counting away from Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-ast.cc

Issue 490173002: Take ast node id counting away from Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: code review (rossberg) Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-ast.cc

diff --git a/test/cctest/test-ast.cc b/test/cctest/test-ast.cc

index a25ae69b6171345733621d12ea43c275e37ea70a..da090c60d394a8b31a5b8be618a842c419064c23 100644

--- a/test/cctest/test-ast.cc

+++ b/test/cctest/test-ast.cc

@@ -41,7 +41,8 @@ TEST(List) {

Isolate* isolate = CcTest::i_isolate();

Zone zone(isolate);

- AstNodeFactory<AstNullVisitor> factory(&zone, NULL);

+ AstNode::IdGen id_gen;

+ AstNodeFactory<AstNullVisitor> factory(&zone, NULL, &id_gen);

AstNode* node = factory.NewEmptyStatement(RelocInfo::kNoPosition);

list->Add(node);

CHECK_EQ(1, list->length());

« src/parser.cc ('K') | « src/zone.h ('k') | no next file » | no next file with comments »