Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: test/cctest/test-ast.cc

Issue 490173002: Take ast node id counting away from Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/zone.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 34
35 using namespace v8::internal; 35 using namespace v8::internal;
36 36
37 TEST(List) { 37 TEST(List) {
38 v8::internal::V8::Initialize(NULL); 38 v8::internal::V8::Initialize(NULL);
39 List<AstNode*>* list = new List<AstNode*>(0); 39 List<AstNode*>* list = new List<AstNode*>(0);
40 CHECK_EQ(0, list->length()); 40 CHECK_EQ(0, list->length());
41 41
42 Isolate* isolate = CcTest::i_isolate(); 42 Isolate* isolate = CcTest::i_isolate();
43 Zone zone(isolate); 43 Zone zone(isolate);
44 AstNodeFactory<AstNullVisitor> factory(&zone, NULL); 44 AstNode::IdGen id_gen;
45 AstNodeFactory<AstNullVisitor> factory(&zone, NULL, &id_gen);
45 AstNode* node = factory.NewEmptyStatement(RelocInfo::kNoPosition); 46 AstNode* node = factory.NewEmptyStatement(RelocInfo::kNoPosition);
46 list->Add(node); 47 list->Add(node);
47 CHECK_EQ(1, list->length()); 48 CHECK_EQ(1, list->length());
48 CHECK_EQ(node, list->at(0)); 49 CHECK_EQ(node, list->at(0));
49 CHECK_EQ(node, list->last()); 50 CHECK_EQ(node, list->last());
50 51
51 const int kElements = 100; 52 const int kElements = 100;
52 for (int i = 0; i < kElements; i++) { 53 for (int i = 0; i < kElements; i++) {
53 list->Add(node); 54 list->Add(node);
54 } 55 }
55 CHECK_EQ(1 + kElements, list->length()); 56 CHECK_EQ(1 + kElements, list->length());
56 57
57 list->Clear(); 58 list->Clear();
58 CHECK_EQ(0, list->length()); 59 CHECK_EQ(0, list->length());
59 delete list; 60 delete list;
60 } 61 }
OLDNEW
« no previous file with comments | « src/zone.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698