Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 490153002: Relanding Now fetching audio test tools from a separate bucket. (Closed)

Created:
6 years, 4 months ago by phoglund_chromium
Modified:
6 years, 4 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Relanding Now fetching audio test tools from a separate bucket. Turns out I had missed force_mic_volume_max.exe. TBR=grunell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291057

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 4 chunks +17 lines, -8 lines 0 comments Download
M chrome/test/data/webrtc/resources/README View 1 chunk +4 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/libgomp-1.dll.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/pesq.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/pesq.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/pthreadgc2.dll.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/sox.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/test/data/webrtc/resources/tools/libgomp-1.dll.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/pesq.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/pesq.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/pthreadgc2.dll.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/sox.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/zlib1.dll.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/webrtc/resources/zlib1.dll.sha1 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 4 months ago (2014-08-21 10:01:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/490153002/1
6 years, 4 months ago (2014-08-21 10:02:15 UTC) #2
phoglund_chromium
The CQ bit was unchecked by phoglund@chromium.org
6 years, 4 months ago (2014-08-21 10:38:53 UTC) #3
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 4 months ago (2014-08-21 10:43:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/490153002/20001
6 years, 4 months ago (2014-08-21 10:44:42 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 13:41:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291057

Powered by Google App Engine
This is Rietveld 408576698