public/web/WebGeolocationController.h - Issue 490143002: Move GeolocationClient to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebGeolocationController.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/web/WebGeolocationController.h

diff --git a/public/web/WebGeolocationController.h b/public/web/WebGeolocationController.h

index 96ca9e8dabd4a89f636b2fed3af275c8280fe897..2c36720737245a97c68e03921431323a3e4c0181 100644

--- a/public/web/WebGeolocationController.h

+++ b/public/web/WebGeolocationController.h

@@ -48,7 +48,7 @@ public:

{

}

- blink::GeolocationController* controller() const { return m_private; }

+ GeolocationController* controller() const { return m_private; }

#endif

private:

@@ -56,6 +56,8 @@ private:

// can be created by the consumers of Chromium WebKit.

WebGeolocationController();

+ // This bare pointer is owned and kept alive by the frame of the

+ // WebLocalFrame which creates this controller object.

GeolocationController* m_private;

};