Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/web/GeolocationClientProxy.cpp

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 void GeolocationClientProxy::setController(GeolocationController* controller) 46 void GeolocationClientProxy::setController(GeolocationController* controller)
47 { 47 {
48 // We support there not being a client, provided we don't do any Geolocation . 48 // We support there not being a client, provided we don't do any Geolocation .
49 if (m_client) { 49 if (m_client) {
50 // Ownership of the WebGeolocationController is transferred to the clien t. 50 // Ownership of the WebGeolocationController is transferred to the clien t.
51 m_client->setController(new WebGeolocationController(controller)); 51 m_client->setController(new WebGeolocationController(controller));
52 } 52 }
53 } 53 }
54 54
55 void GeolocationClientProxy::geolocationDestroyed()
56 {
57 if (m_client)
58 m_client->geolocationDestroyed();
59 }
60
61 void GeolocationClientProxy::startUpdating() 55 void GeolocationClientProxy::startUpdating()
62 { 56 {
63 m_client->startUpdating(); 57 m_client->startUpdating();
64 } 58 }
65 59
66 void GeolocationClientProxy::stopUpdating() 60 void GeolocationClientProxy::stopUpdating()
67 { 61 {
68 m_client->stopUpdating(); 62 m_client->stopUpdating();
69 } 63 }
70 64
(...skipping 16 matching lines...) Expand all
87 void GeolocationClientProxy::requestPermission(Geolocation* geolocation) 81 void GeolocationClientProxy::requestPermission(Geolocation* geolocation)
88 { 82 {
89 m_client->requestPermission(WebGeolocationPermissionRequest(geolocation)); 83 m_client->requestPermission(WebGeolocationPermissionRequest(geolocation));
90 } 84 }
91 85
92 void GeolocationClientProxy::cancelPermissionRequest(Geolocation* geolocation) 86 void GeolocationClientProxy::cancelPermissionRequest(Geolocation* geolocation)
93 { 87 {
94 m_client->cancelPermissionRequest(WebGeolocationPermissionRequest(geolocatio n)); 88 m_client->cancelPermissionRequest(WebGeolocationPermissionRequest(geolocatio n));
95 } 89 }
96 90
91 void GeolocationClientProxy::trace(Visitor* visitor)
92 {
93 visitor->trace(m_lastPosition);
94 GeolocationClient::trace(visitor);
95 }
96
97 } // namespace blink 97 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698