Revert of MacViews: Fix WebDialogBrowserTest.SizeWindow to get browser_tests compiling on MacViews

Revert of MacViews: Fix WebDialogBrowserTest.SizeWindow to get browser_tests compiling on MacViews (patchset #7 of https://codereview.chromium.org/486063002/)

Reason for revert:
browser_test fails in Linux ASAN/LSAN test.

WebDialogBrowserTest.SizeWindow (run #1):
[ RUN      ] WebDialogBrowserTest.SizeWindow
[30383:30383:0820/232516:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[30383:30383:0820/232516:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
[30473:30473:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox
[30496:30496:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox

=================================================================
==30383==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 128 byte(s) in 1 object(s) allocated from:
    #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb)
    #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3
    #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5
    #3 0x2d6de03 in Run base/callback.h:401:12
    #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555
    #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18
    #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5
    #7 0x5d3ac48 in Run base/callback.h:401:12
    #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3
    #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5
    #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19
    #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12
    #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15
    #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3
    #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3
    #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12
    #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430
    #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227
    #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12
    #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12
    #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10
    #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10
    #29 0x7feeddc6676c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

-----------------------------------------------------
Suppressions used:
  count      bytes template
   1767      75328 libfontconfig
-----------------------------------------------------

SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s).
[0820/232518:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox!
Most likely you need to configure your SUID sandbox correctly

WebDialogBrowserTest.SizeWindow (run #2):
[ RUN      ] WebDialogBrowserTest.SizeWindow
[16767:16767:0820/232720:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[16767:16767:0820/232720:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
[16871:16871:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox
[16911:16911:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox

=================================================================
==16767==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 128 byte(s) in 1 object(s) allocated from:
    #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb)
    #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3
    #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5
    #3 0x2d6de03 in Run base/callback.h:401:12
    #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555
    #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18
    #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5
    #7 0x5d3ac48 in Run base/callback.h:401:12
    #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3
    #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5
    #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19
    #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12
    #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15
    #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3
    #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3
    #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12
    #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430
    #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227
    #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12
    #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12
    #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10
    #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10
    #29 0x7fb13f28476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

-----------------------------------------------------
Suppressions used:
  count      bytes template
   1767      75328 libfontconfig
-----------------------------------------------------

SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s).
[0820/232722:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox!
Most likely you need to configure your SUID sandbox correctly

WebDialogBrowserTest.SizeWindow (run #3):
[ RUN      ] WebDialogBrowserTest.SizeWindow
[16994:16994:0820/232723:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[16994:16994:0820/232724:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
[17026:17026:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox
[17038:17038:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox

=================================================================
==16994==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 128 byte(s) in 1 object(s) allocated from:
    #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb)
    #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3
    #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5
    #3 0x2d6de03 in Run base/callback.h:401:12
    #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555
    #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18
    #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5
    #7 0x5d3ac48 in Run base/callback.h:401:12
    #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3
    #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5
    #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19
    #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12
    #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15
    #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3
    #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3
    #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12
    #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430
    #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227
    #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12
    #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12
    #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10
    #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10
    #29 0x7f0688ff376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

-----------------------------------------------------
Suppressions used:
  count      bytes template
   1767      75328 libfontconfig
-----------------------------------------------------

SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s).
[0820/232725:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox!
Most likely you need to configure your SUID sandbox correctly

WebDialogBrowserTest.SizeWindow (run #4):
[ RUN      ] WebDialogBrowserTest.SizeWindow
[17073:17073:0820/232726:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[17073:17073:0820/232726:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
[17105:17105:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox
[17116:17116:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox

=================================================================
==17073==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 128 byte(s) in 1 object(s) allocated from:
    #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb)
    #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3
    #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5
    #3 0x2d6de03 in Run base/callback.h:401:12
    #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555
    #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18
    #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5
    #7 0x5d3ac48 in Run base/callback.h:401:12
    #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3
    #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5
    #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19
    #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12
    #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15
    #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3
    #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3
    #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12
    #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430
    #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227
    #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12
    #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12
    #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10
    #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10
    #29 0x7f5f8410c76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

-----------------------------------------------------
Suppressions used:
  count      bytes template
   1767      75328 libfontconfig
-----------------------------------------------------

SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s).
[0820/232728:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox!
Most likely you need to configure your SUID sandbox correctly

Original issue's description:
> MacViews: Fix WebDialogBrowserTest.SizeWindow to get browser_tests compiling on MacViews
> 
> gyp changes are made to filter out toolkit-views browser_tests that
> aren't yet compiled in to a toolkit-views Chrome binary on Mac.
> 
> One, WebDialogBrowserTest.SizeWindow, was a disabled test (disabled for
> 4 years :o). It was preventing browser_tests compiling on MacViews
> because it was passing a gfx::NativeWindow to CreateWindowWithParent,
> which takes a view.
> 
> The parent isn't important for the test - it's just adding widget
> context. This CL changes the parent to be web_contents->GetNativeView()
> instead so the test compiles.
> 
> To ensure nothing breaks, the test needs to be enabled. According to the
> comment, the reasons for it being disabled on Windows still seem
> relevant. However, on Linux the test was just timing out due to a quirk
> of the test. So the quirk is fixed, and WebDialogBrowserTest.SizeWindow
> is enabled on Linux Aura.
> 
> The test is also enabled on Mac, but currently fails because
> NativeViewHost isn't implemented yet. That's coming, and leaving the
> test enabled will ensure we check it.
> 
> With this change browser_tests compiles and links on toolkit-views Mac.
> 
> BUG=404979, 399191, 52602
> TEST=browser_tests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290998

TBR=msw@chromium.org,tapted@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404979, 399191, 52602
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291014

[peria, 2014-08-21 07:00:17]

Created Revert of MacViews: Fix WebDialogBrowserTest.SizeWindow to get
browser_tests compiling on MacViews

[commit-bot: I haz the power, 2014-08-21 07:00:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/490123002/1

[commit-bot: I haz the power, 2014-08-21 07:02:22]

Committed patchset #1 (1) as 291014