Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 490103003: Use the host instead of the title for streamlined hosted apps. (Closed)

Created:
6 years, 4 months ago by benwells
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use the host instead of the title for streamlined hosted apps. As there is no URL being displayed users need to be aware of what host they are on for security reasons. This is part of the experimental streamlined hosted apps window frame. BUG=368372 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291305

Patch Set 1 #

Patch Set 2 : Tweaked #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benwells
(whichever of this and https://codereview.chromium.org/489313002/ gets stamped last will get slightly updated)
6 years, 4 months ago (2014-08-21 06:55:59 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-21 16:43:47 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 4 months ago (2014-08-21 22:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/490103003/20001
6 years, 4 months ago (2014-08-21 22:22:34 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:38:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291305

Powered by Google App Engine
This is Rietveld 408576698