Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/app/chrome_main.cc

Issue 490043002: Improve the ScopedHandle verifier. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Common sources section Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/close_handle_hook_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_main_delegate.h" 5 #include "chrome/app/chrome_main_delegate.h"
6 6
7 #include "content/public/app/content_main.h" 7 #include "content/public/app/content_main.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include "base/debug/dump_without_crashing.h" 10 #include "base/debug/dump_without_crashing.h"
11 #include "base/win/win_util.h" 11 #include "base/win/win_util.h"
12 #include "chrome/app/close_handle_hook_win.h"
12 #include "chrome/common/chrome_constants.h" 13 #include "chrome/common/chrome_constants.h"
13 14
14 #define DLLEXPORT __declspec(dllexport) 15 #define DLLEXPORT __declspec(dllexport)
15 16
16 // We use extern C for the prototype DLLEXPORT to avoid C++ name mangling. 17 // We use extern C for the prototype DLLEXPORT to avoid C++ name mangling.
17 extern "C" { 18 extern "C" {
18 DLLEXPORT int __cdecl ChromeMain(HINSTANCE instance, 19 DLLEXPORT int __cdecl ChromeMain(HINSTANCE instance,
19 sandbox::SandboxInterfaceInfo* sandbox_info); 20 sandbox::SandboxInterfaceInfo* sandbox_info);
20 } 21 }
21 #elif defined(OS_POSIX) 22 #elif defined(OS_POSIX)
(...skipping 12 matching lines...) Expand all
34 ChromeMainDelegate chrome_main_delegate; 35 ChromeMainDelegate chrome_main_delegate;
35 content::ContentMainParams params(&chrome_main_delegate); 36 content::ContentMainParams params(&chrome_main_delegate);
36 37
37 #if defined(OS_WIN) 38 #if defined(OS_WIN)
38 // The process should crash when going through abnormal termination. 39 // The process should crash when going through abnormal termination.
39 base::win::SetShouldCrashOnProcessDetach(true); 40 base::win::SetShouldCrashOnProcessDetach(true);
40 base::win::SetAbortBehaviorForCrashReporting(); 41 base::win::SetAbortBehaviorForCrashReporting();
41 params.instance = instance; 42 params.instance = instance;
42 params.sandbox_info = sandbox_info; 43 params.sandbox_info = sandbox_info;
43 44
45 InstallCloseHandleHooks();
46
44 // SetDumpWithoutCrashingFunction must be passed the DumpProcess function 47 // SetDumpWithoutCrashingFunction must be passed the DumpProcess function
45 // from the EXE and not from the DLL in order for DumpWithoutCrashing to 48 // from the EXE and not from the DLL in order for DumpWithoutCrashing to
46 // function correctly. 49 // function correctly.
47 typedef void (__cdecl *DumpProcessFunction)(); 50 typedef void (__cdecl *DumpProcessFunction)();
48 DumpProcessFunction DumpProcess = reinterpret_cast<DumpProcessFunction>( 51 DumpProcessFunction DumpProcess = reinterpret_cast<DumpProcessFunction>(
49 ::GetProcAddress(::GetModuleHandle(chrome::kBrowserProcessExecutableName), 52 ::GetProcAddress(::GetModuleHandle(chrome::kBrowserProcessExecutableName),
50 "DumpProcessWithoutCrash")); 53 "DumpProcessWithoutCrash"));
51 base::debug::SetDumpWithoutCrashingFunction(DumpProcess); 54 base::debug::SetDumpWithoutCrashingFunction(DumpProcess);
52 #else 55 #else
53 params.argc = argc; 56 params.argc = argc;
54 params.argv = argv; 57 params.argv = argv;
55 #endif 58 #endif
56 59
57 int rv = content::ContentMain(params); 60 int rv = content::ContentMain(params);
58 61
59 #if defined(OS_WIN) 62 #if defined(OS_WIN)
63 RemoveCloseHandleHooks();
60 base::win::SetShouldCrashOnProcessDetach(false); 64 base::win::SetShouldCrashOnProcessDetach(false);
61 #endif 65 #endif
62 66
63 return rv; 67 return rv;
64 } 68 }
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/close_handle_hook_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698