athena/home/home_card_impl.cc - Issue 490033003: Fixes three crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/home/home_card_impl.cc

Issue 490033003: Fixes three crashes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/home/home_card_impl.cc

diff --git a/athena/home/home_card_impl.cc b/athena/home/home_card_impl.cc

index 9a8526d8c36be6653adc847d33f9a8112121777a..d16ff9c24a08b071286e2afee5a614d1dfbf9aa2 100644

--- a/athena/home/home_card_impl.cc

+++ b/athena/home/home_card_impl.cc

@@ -486,6 +486,11 @@ HomeCardImpl::~HomeCardImpl() {

if (activation_client_)

activation_client_->RemoveObserver(this);

home_card_widget_->CloseNow();

+ // Reset the view delegate first as it access search provider during

+ // shutdown.

+ view_delegate_.reset();

+ search_provider_.reset();

instance = NULL;

}