Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: media/base/video_decoder.h

Issue 490033002: Don't try to decode more than one EOS at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO for decoding_eos_ -> State. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/decoder_stream.h » ('j') | media/filters/video_frame_stream_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index edca238e784a03c04233db1e0f66c89a0d445b16..89c62dbe4c409f758d9167d9c299c95058c06cfa 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -69,7 +69,7 @@ class MEDIA_EXPORT VideoDecoder {
//
// Implementations guarantee that the callback will not be called from within
// this method and that |decode_cb| will not be blocked on the following
- // Decode() calls (i.e. |decode_cb| will be called even Decode() is never
+ // Decode() calls (i.e. |decode_cb| will be called even if Decode() is never
// called again).
//
// After decoding is finished the decoder calls |output_cb| specified in
@@ -78,7 +78,8 @@ class MEDIA_EXPORT VideoDecoder {
//
// If |buffer| is an EOS buffer then the decoder must be flushed, i.e.
// |output_cb| must be called for each frame pending in the queue and
- // |decode_cb| must be called after that.
+ // |decode_cb| must be called after that. Callers will not call Decode()
+ // again until after the flush completes.
virtual void Decode(const scoped_refptr<DecoderBuffer>& buffer,
const DecodeCB& decode_cb) = 0;
« no previous file with comments | « no previous file | media/filters/decoder_stream.h » ('j') | media/filters/video_frame_stream_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698