[Profiles, SyzyASAN] Remove incorrect use of profile_ on the IO thread.

[Profiles, SyzyASAN] Remove incorrect use of profile_ on the IO thread.

BUG=290974
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233502

[jam, 2013-10-28 20:20:50]

https://codereview.chromium.org/49003003/diff/1/chrome/browser/renderer_host/...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://codereview.chromium.org/49003003/diff/1/chrome/browser/renderer_host/...
chrome/browser/renderer_host/chrome_render_message_filter.cc:199: if (profile_
&& profile_->GetNetworkPredictor())
this code isn't thread safe, that's probably why this is crashing.

Profile is not thread safe, and should only be accessed on the UI thread. It
seems that all the places in this file that use profile_ are incorrect and need
to be fixed up. At construction of this class, whatever objects are needed
(which are safe to use on the IO thread) should have pointers to them stashed.

[rpetterson, 2013-10-29 00:50:30]

On 2013/10/28 20:20:50, jam wrote:
>
https://codereview.chromium.org/49003003/diff/1/chrome/browser/renderer_host/...
> File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):
> 
>
https://codereview.chromium.org/49003003/diff/1/chrome/browser/renderer_host/...
> chrome/browser/renderer_host/chrome_render_message_filter.cc:199: if (profile_
> && profile_->GetNetworkPredictor())
> this code isn't thread safe, that's probably why this is crashing.
> 
> Profile is not thread safe, and should only be accessed on the UI thread. It
> seems that all the places in this file that use profile_ are incorrect and
need
> to be fixed up. At construction of this class, whatever objects are needed
> (which are safe to use on the IO thread) should have pointers to them stashed.


I've updated the CL (and the description) to make sure profile_ is only being
used on the UI thread. PTAL.

Also, adding in kalman@ to make sure I didn't adversely affect any of the
extension parts.

[not at google - send to devlin, 2013-10-29 14:30:02]

lgtm

[jam, 2013-10-29 17:09:23]

https://codereview.chromium.org/49003003/diff/80001/chrome/browser/renderer_h...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (left):

https://codereview.chromium.org/49003003/diff/80001/chrome/browser/renderer_h...
chrome/browser/renderer_host/chrome_render_message_filter.cc:406:
extensions::ExtensionSystem::Get(profile_)->event_router()->AddEventListener(
this method runs on the UI thread, see OverrideThreadForMessage. same for all
the extension IPCs below

[rpetterson, 2013-10-29 23:22:33]

https://codereview.chromium.org/49003003/diff/80001/chrome/browser/renderer_h...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (left):

https://codereview.chromium.org/49003003/diff/80001/chrome/browser/renderer_h...
chrome/browser/renderer_host/chrome_render_message_filter.cc:406:
extensions::ExtensionSystem::Get(profile_)->event_router()->AddEventListener(
On 2013/10/29 17:09:24, jam wrote:
> this method runs on the UI thread, see OverrideThreadForMessage. same for all
> the extension IPCs below

In that case, it looks like the predictor ones were the only ones that were a
problem. PTAL.

[jam, 2013-10-30 01:28:19]

lgtm

[commit-bot: I haz the power, 2013-11-07 02:24:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/49003003/170001

[commit-bot: I haz the power, 2013-11-07 06:26:51]

Change committed as 233502