Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
489983003:
Load menu_item.js before menu.js on chrome://apps page (Closed)
|
Created:
6 years, 4 months ago by Vitaly Pavlenko Modified:
6 years, 4 months ago Reviewers:
Dan Beam CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master Project:
chromium Visibility:
Public. |
DescriptionLoad menu_item.js before menu.js on chrome://apps page
BUG=405486
R=dbeam@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291151
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
The CQ bit was checked by dbeam@chromium.org
lgtm oh, you didn't tell me it was on chrome://apps... I helped write this, haha.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/489983003/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by vitalyp@chromium.org
The CQ bit was unchecked by vitalyp@chromium.org
The CQ bit was checked by vitalyp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/489983003/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by vitalyp@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/489983003/1
Message was sent while issue was closed.
Committed patchset #1 (1) as 291151 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
