Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

Issue 489943002: Don't recompute the package graph unnecessarily in Entrypoint. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
diff --git a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
index ec276ea22d0911d0c8185405897348840e056534..471f09536e2046b123870421793fdda69e2917d2 100644
--- a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
+++ b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
@@ -53,6 +53,10 @@ class SolveResult {
/// The dependency overrides that were used in the solution.
final List<PackageDep> overrides;
+ /// A map from package names to the pubspecs for the versions of those
+ /// packages that were installed, or `null` if the solver failed.
+ final Map<String, Pubspec> pubspecs;
+
/// The available versions of all selected packages from their source.
///
/// Will be empty if the solve failed. An entry here may not include the full
@@ -76,13 +80,14 @@ class SolveResult {
final LockFile _previousLockFile;
SolveResult.success(this._sources, this._root, this._previousLockFile,
- this.packages, this.overrides, this.availableVersions,
+ this.packages, this.overrides, this.pubspecs, this.availableVersions,
this.attemptedSolutions)
: error = null;
SolveResult.failure(this._sources, this._root, this._previousLockFile,
this.overrides, this.error, this.attemptedSolutions)
: this.packages = null,
+ this.pubspecs = null,
this.availableVersions = {};
/// Displays a report of what changes were made to the lockfile.
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698