Issue 489893002: DevTools: add support for chrome-devtools://devtools/remote/open? URL.

Issue 489893002: DevTools: add support for chrome-devtools://devtools/remote/open? URL. (Closed)

Created:
6 years, 4 months ago by dgozman

Modified:
6 years, 4 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: add support for chrome-devtools://devtools/remote/open? URL. BUG=370025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291382

Patch Set 2 : fixed comment, guard by experiment #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -8 lines)			Patch
M	chrome/browser/devtools/devtools_ui_bindings.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/devtools_ui.h	View		1 chunk	+16 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/devtools_ui.cc	View	1	6 chunks	+164 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dgozman

Take a look please. This seems to work for any navigations. Guarded by devtools experiments ...

6 years, 4 months ago (2014-08-20 16:53:45 UTC) #1

pfeldman

lgtm https://codereview.chromium.org/489893002/diff/1/chrome/browser/ui/webui/devtools_ui.cc File chrome/browser/ui/webui/devtools_ui.cc (right): https://codereview.chromium.org/489893002/diff/1/chrome/browser/ui/webui/devtools_ui.cc#newcode262 chrome/browser/ui/webui/devtools_ui.cc:262: virtual void DeviceListChanged( private:

6 years, 4 months ago (2014-08-21 12:38:46 UTC) #2

dgozman

https://codereview.chromium.org/489893002/diff/1/chrome/browser/ui/webui/devtools_ui.cc File chrome/browser/ui/webui/devtools_ui.cc (right): https://codereview.chromium.org/489893002/diff/1/chrome/browser/ui/webui/devtools_ui.cc#newcode262 chrome/browser/ui/webui/devtools_ui.cc:262: virtual void DeviceListChanged( On 2014/08/21 12:38:46, pfeldman wrote: > ...

6 years, 4 months ago (2014-08-22 09:03:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/489893002/20001

6 years, 4 months ago (2014-08-22 09:04:40 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 10:45:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 291382

Expand Messages | Collapse Messages