Issue 489853002: copy points in array that may stretch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 489853002: copy points in array that may stretch (Closed)

Created:
6 years, 4 months ago by caryclark

Modified:
6 years, 4 months ago

Reviewers:
f(malita), fmalita_google_do_not_use

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

copy points in array that may stretch Description: Potential SkOpSegment::addT() use-after-free The 'pt' arg can be a reference to a point stored in the local fTs TDArray => appending may cause a realloc and leave the reference pointing to deallocated mem. Copy the points from the stretchy array before adding them. R=fmalita BUG=405417 Committed: https://skia.googlesource.com/skia/+/bdbb2422b9f20372597367a032d822b4297eab41

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/pathops/SkOpSegment.cpp	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/489853002/1

6 years, 4 months ago (2014-08-20 14:57:17 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-20 15:11:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as bdbb2422b9f20372597367a032d822b4297eab41

Expand Messages | Collapse Messages