Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 489823003: Disable the new avatar menu in a test. (Closed)

Created:
6 years, 3 months ago by Marc Treib
Modified:
6 years, 3 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable the new avatar menu in a test. This will make the test not fail once the new avatar menu is enabled by default. BUG=400667 Committed: https://crrev.com/33335ad1891e9de1c0a8deff2df4adb88812d6c2 Cr-Commit-Position: refs/heads/master@{#292126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/profiles/profile_info_cache_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Marc Treib
treib@chromium.org changed reviewers: + noms@chromium.org
6 years, 3 months ago (2014-08-26 09:04:16 UTC) #1
Marc Treib
PTAL!
6 years, 3 months ago (2014-08-26 09:04:16 UTC) #2
noms (inactive)
Oh oops, you're totally right. Thanks! lgtm
6 years, 3 months ago (2014-08-26 19:48:19 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 3 months ago (2014-08-27 07:35:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/489823003/1
6 years, 3 months ago (2014-08-27 07:35:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 08:23:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 1b01cf4eb77bd6839756263ab824ee7f3770f1c6
6 years, 3 months ago (2014-08-27 09:17:35 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33335ad1891e9de1c0a8deff2df4adb88812d6c2
Cr-Commit-Position: refs/heads/master@{#292126}

Powered by Google App Engine
This is Rietveld 408576698