Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: extensions/common/manifest_constants.cc

Issue 489753002: Added proper extension manifest parser for launcher_page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add ASSERT in test (avoid NULL deref if it happens to have failed). Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/manifest_constants.h" 5 #include "extensions/common/manifest_constants.h"
6 6
7 namespace extensions { 7 namespace extensions {
8 8
9 namespace manifest_keys { 9 namespace manifest_keys {
10 10
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 "Too many shortcuts specified for 'commands': The maximum is *."; 457 "Too many shortcuts specified for 'commands': The maximum is *.";
458 const char kInvalidKeyBindingUnknownPlatform[] = 458 const char kInvalidKeyBindingUnknownPlatform[] =
459 "Unknown platform for 'command[*]': *. Valid values are: 'windows', 'mac'" 459 "Unknown platform for 'command[*]': *. Valid values are: 'windows', 'mac'"
460 " 'chromeos', 'linux' and 'default'."; 460 " 'chromeos', 'linux' and 'default'.";
461 const char kInvalidKioskEnabled[] = 461 const char kInvalidKioskEnabled[] =
462 "Invalid value for 'kiosk_enabled'."; 462 "Invalid value for 'kiosk_enabled'.";
463 const char kInvalidKioskOnly[] = 463 const char kInvalidKioskOnly[] =
464 "Invalid value for 'kiosk_only'."; 464 "Invalid value for 'kiosk_only'.";
465 const char kInvalidKioskOnlyButNotEnabled[] = 465 const char kInvalidKioskOnlyButNotEnabled[] =
466 "The 'kiosk_only' key is set, but 'kiosk_enabled' is not set."; 466 "The 'kiosk_only' key is set, but 'kiosk_enabled' is not set.";
467 const char kInvalidLauncherPage[] = "Invalid value for 'launcher_page'.";
468 const char kInvalidLauncherPagePage[] =
469 "Invalid value for 'launcher_page.page'.";
467 const char kInvalidLaunchContainer[] = 470 const char kInvalidLaunchContainer[] =
468 "Invalid value for 'app.launch.container'."; 471 "Invalid value for 'app.launch.container'.";
469 const char kInvalidLaunchValue[] = 472 const char kInvalidLaunchValue[] =
470 "Invalid value for '*'."; 473 "Invalid value for '*'.";
471 const char kInvalidLaunchValueContainer[] = 474 const char kInvalidLaunchValueContainer[] =
472 "Invalid container type for '*'."; 475 "Invalid container type for '*'.";
473 const char kInvalidManifest[] = 476 const char kInvalidManifest[] =
474 "Manifest file is invalid."; 477 "Manifest file is invalid.";
475 const char kInvalidManifestVersion[] = 478 const char kInvalidManifestVersion[] =
476 "Invalid value for 'manifest_version'. Must be an integer greater than " 479 "Invalid value for 'manifest_version'. Must be an integer greater than "
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 const char kInsecureContentSecurityPolicy[] = 661 const char kInsecureContentSecurityPolicy[] =
659 "Invalid value for 'content_security_policy': Both 'script-src' and" 662 "Invalid value for 'content_security_policy': Both 'script-src' and"
660 " 'object-src' directives must be specified (either explicitly, or" 663 " 'object-src' directives must be specified (either explicitly, or"
661 " implicitly via 'default-src'), and both must whitelist only secure" 664 " implicitly via 'default-src'), and both must whitelist only secure"
662 " resources. You may include any of the following sources: \"'self'\"," 665 " resources. You may include any of the following sources: \"'self'\","
663 " \"'unsafe-eval'\", \"http://127.0.0.1\", \"http://localhost\", or any" 666 " \"'unsafe-eval'\", \"http://127.0.0.1\", \"http://localhost\", or any"
664 " \"https://\" or \"chrome-extension://\" origin. For more information," 667 " \"https://\" or \"chrome-extension://\" origin. For more information,"
665 " see http://developer.chrome.com/extensions/contentSecurityPolicy.html"; 668 " see http://developer.chrome.com/extensions/contentSecurityPolicy.html";
666 const char kKeyIsDeprecatedWithReplacement[] = 669 const char kKeyIsDeprecatedWithReplacement[] =
667 "Key \"*\" is deprecated. Key \"*\" should be used instead."; 670 "Key \"*\" is deprecated. Key \"*\" should be used instead.";
671 const char kLauncherPagePageRequired[] =
672 "The 'launcher_page.page' key is required.";
668 const char kLaunchPathAndExtentAreExclusive[] = 673 const char kLaunchPathAndExtentAreExclusive[] =
669 "The 'app.launch.local_path' and 'app.urls' keys cannot both be set."; 674 "The 'app.launch.local_path' and 'app.urls' keys cannot both be set.";
670 const char kLaunchPathAndURLAreExclusive[] = 675 const char kLaunchPathAndURLAreExclusive[] =
671 "The 'app.launch.local_path' and 'app.launch.web_url' keys cannot " 676 "The 'app.launch.local_path' and 'app.launch.web_url' keys cannot "
672 "both be set."; 677 "both be set.";
673 const char kLaunchURLRequired[] = 678 const char kLaunchURLRequired[] =
674 "Either 'app.launch.local_path' or 'app.launch.web_url' is required."; 679 "Either 'app.launch.local_path' or 'app.launch.web_url' is required.";
675 const char kLocalesInvalidLocale[] = 680 const char kLocalesInvalidLocale[] =
676 "Invalid locale file '*': *"; 681 "Invalid locale file '*': *";
677 const char kLocalesMessagesFileMissing[] = 682 const char kLocalesMessagesFileMissing[] =
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 const char kWebRequestConflictsWithLazyBackground[] = 730 const char kWebRequestConflictsWithLazyBackground[] =
726 "The 'webRequest' API cannot be used with event pages."; 731 "The 'webRequest' API cannot be used with event pages.";
727 #if defined(OS_CHROMEOS) 732 #if defined(OS_CHROMEOS)
728 const char kIllegalPlugins[] = 733 const char kIllegalPlugins[] =
729 "Extensions cannot install plugins on Chrome OS"; 734 "Extensions cannot install plugins on Chrome OS";
730 #endif 735 #endif
731 736
732 } // namespace manifest_errors 737 } // namespace manifest_errors
733 738
734 } // namespace extensions 739 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698