Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 489753002: Added proper extension manifest parser for launcher_page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add ASSERT in test (avoid NULL deref if it happens to have failed). Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h"
5 #include "base/i18n/rtl.h" 6 #include "base/i18n/rtl.h"
6 #include "base/path_service.h" 7 #include "base/path_service.h"
7 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/common/chrome_paths.h" 9 #include "chrome/common/chrome_paths.h"
9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
10 #include "chrome/common/extensions/manifest_url_handler.h" 11 #include "chrome/common/extensions/manifest_url_handler.h"
11 #include "extensions/common/extension.h" 12 #include "extensions/common/extension.h"
12 #include "extensions/common/manifest_constants.h" 13 #include "extensions/common/manifest_constants.h"
14 #include "extensions/common/switches.h"
13 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
14 #include "ui/base/l10n/l10n_util.h" 16 #include "ui/base/l10n/l10n_util.h"
15 17
16 namespace extensions { 18 namespace extensions {
17 19
20 namespace {
21
22 // The ID of test manifests requiring whitelisting.
23 const char kWhitelistID[] = "lmadimbbgapmngbiclpjjngmdickadpl";
24
25 } // namespace
26
18 namespace errors = manifest_errors; 27 namespace errors = manifest_errors;
19 namespace keys = manifest_keys; 28 namespace keys = manifest_keys;
20 29
21 class InitValueManifestTest : public ExtensionManifestTest { 30 class InitValueManifestTest : public ExtensionManifestTest {
22 }; 31 };
23 32
24 TEST_F(InitValueManifestTest, InitFromValueInvalid) { 33 TEST_F(InitValueManifestTest, InitFromValueInvalid) {
34 CommandLine::ForCurrentProcess()->AppendSwitchASCII(
35 extensions::switches::kWhitelistedExtensionID, kWhitelistID);
25 Testcase testcases[] = { 36 Testcase testcases[] = {
26 Testcase("init_invalid_version_missing.json", errors::kInvalidVersion), 37 Testcase("init_invalid_version_missing.json", errors::kInvalidVersion),
27 Testcase("init_invalid_version_invalid.json", errors::kInvalidVersion), 38 Testcase("init_invalid_version_invalid.json", errors::kInvalidVersion),
28 Testcase("init_invalid_name_missing.json", errors::kInvalidName), 39 Testcase("init_invalid_name_missing.json", errors::kInvalidName),
29 Testcase("init_invalid_name_invalid.json", errors::kInvalidName), 40 Testcase("init_invalid_name_invalid.json", errors::kInvalidName),
30 Testcase("init_invalid_description_invalid.json", 41 Testcase("init_invalid_description_invalid.json",
31 errors::kInvalidDescription), 42 errors::kInvalidDescription),
32 Testcase("init_invalid_icons_invalid.json", errors::kInvalidIcons), 43 Testcase("init_invalid_icons_invalid.json", errors::kInvalidIcons),
33 Testcase("init_invalid_icons_path_invalid.json", errors::kInvalidIconPath), 44 Testcase("init_invalid_icons_path_invalid.json", errors::kInvalidIconPath),
45 Testcase("init_invalid_launcher_page_invalid.json",
46 errors::kInvalidLauncherPage),
47 Testcase("init_invalid_launcher_page_page_missing.json",
48 errors::kLauncherPagePageRequired),
49 Testcase("init_invalid_launcher_page_page_invalid.json",
50 errors::kInvalidLauncherPagePage),
34 Testcase("init_invalid_script_invalid.json", 51 Testcase("init_invalid_script_invalid.json",
35 errors::kInvalidContentScriptsList), 52 errors::kInvalidContentScriptsList),
36 Testcase("init_invalid_script_item_invalid.json", 53 Testcase("init_invalid_script_item_invalid.json",
37 errors::kInvalidContentScript), 54 errors::kInvalidContentScript),
38 Testcase("init_invalid_script_matches_missing.json", 55 Testcase("init_invalid_script_matches_missing.json",
39 errors::kInvalidMatches), 56 errors::kInvalidMatches),
40 Testcase("init_invalid_script_matches_invalid.json", 57 Testcase("init_invalid_script_matches_invalid.json",
41 errors::kInvalidMatches), 58 errors::kInvalidMatches),
42 Testcase("init_invalid_script_matches_empty.json", 59 Testcase("init_invalid_script_matches_empty.json",
43 errors::kInvalidMatchCount), 60 errors::kInvalidMatchCount),
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 170
154 localized_name = base::WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)"); 171 localized_name = base::WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)");
155 base::i18n::AdjustStringForLocaleDirection(&localized_name); 172 base::i18n::AdjustStringForLocaleDirection(&localized_name);
156 EXPECT_EQ(localized_name, base::UTF8ToUTF16(extension->name())); 173 EXPECT_EQ(localized_name, base::UTF8ToUTF16(extension->name()));
157 174
158 // Reset locale. 175 // Reset locale.
159 base::i18n::SetICUDefaultLocale(locale); 176 base::i18n::SetICUDefaultLocale(locale);
160 } 177 }
161 178
162 } // namespace extensions 179 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698