Added proper extension manifest parser for launcher_page.

extensions/common/manifest_handlers/launcher_page_info.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/common/manifest_handlers/launcher_page_info.h"
+
+#include "base/files/file_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "extensions/common/manifest.h"
+#include "extensions/common/manifest_constants.h"
+#include "grit/extensions_strings.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace extensions {
+
+LauncherPageHandler::LauncherPageHandler() {
+}
+
+LauncherPageHandler::~LauncherPageHandler() {
+}
+
+bool LauncherPageHandler::Parse(Extension* extension, base::string16* error) {
+  const extensions::Manifest* manifest = extension->manifest();
+  scoped_ptr<LauncherPageInfo> launcher_page_info(new LauncherPageInfo);
+  const base::DictionaryValue* launcher_page_dict = NULL;
+  if (!manifest->GetDictionary(manifest_keys::kLauncherPage,
+                               &launcher_page_dict)) {
+    *error = base::ASCIIToUTF16(manifest_errors::kInvalidLauncherPage);
+    return false;
+  }
+
+  if (!manifest->HasPath(extensions::manifest_keys::kLauncherPagePage)) {
+    *error = base::ASCIIToUTF16(manifest_errors::kLauncherPagePageRequired);
+    return false;
+  }

[calamity, 2014/08/21 02:53:08]

nit: blank line after early return

[Matt Giuca, 2014/08/22 02:48:41]

Done.

+  std::string launcher_page_page;
+  if (!manifest->GetString(extensions::manifest_keys::kLauncherPagePage,
+                           &launcher_page_page)) {
+    *error = base::ASCIIToUTF16(manifest_errors::kInvalidLauncherPagePage);
+    return false;
+  }

[calamity, 2014/08/21 02:53:08]

nit: blank line after early return

[Matt Giuca, 2014/08/22 02:48:40]

Done.

+  launcher_page_info->page = launcher_page_page;
+
+  extension->SetManifestData(manifest_keys::kLauncherPage,
+                             launcher_page_info.release());
+  return true;
+}
+
+bool LauncherPageHandler::Validate(
+    const Extension* extension,
+    std::string* error,
+    std::vector<InstallWarning>* warnings) const {
+  LauncherPageInfo* info = static_cast<LauncherPageInfo*>(
+      extension->GetManifestData(manifest_keys::kLauncherPage));

[calamity, 2014/08/21 02:53:08]

Other manufest handlers seem to have a static Get() method that does this cast
instead of casting it everywhere. See icons_handler.h.

[Matt Giuca, 2014/08/22 02:48:40]

Actually icons_handler is what I copied this off and it does the static_cast
manually (albeit only in one place).

But I'll do this anyway because it's much neater and safer.

+  const base::FilePath path = extension->GetResource(info->page).GetFilePath();
+  if (!base::PathExists(path)) {
+    *error = l10n_util::GetStringFUTF8(IDS_EXTENSION_LOAD_LAUNCHER_PAGE_FAILED,
+                                       base::UTF8ToUTF16(info->page));
+    return false;
+  }

[calamity, 2014/08/21 02:53:08]

nit: blank line after early return

[Matt Giuca, 2014/08/22 02:48:41]

Done.

+  return true;
+}
+
+const std::vector<std::string> LauncherPageHandler::Keys() const {
+  return SingleKey(manifest_keys::kLauncherPage);
+}
+
+}  // namespace extensions