Add font fallback support to SkFontMgr_fontconfig.

Add font fallback support to SkFontMgr_fontconfig.

Committed: https://skia.googlesource.com/skia/+/6bc2c94de334efb40e1a09e31112262dec77532b

[bungeman-skia, 2014-08-27 17:51:07]

bungeman@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[bungeman-skia, 2014-08-27 17:51:07]

This adds fallback support to the new SkFontMgr_fontconfig, and makes the new
fontmgr_iter gm select the right fonts. We even get emoji (though not currently
in color), at least on my machine.

[mtklein, 2014-08-28 21:32:24]

lgtm

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
File src/ports/SkFontMgr_fontconfig.cpp (right):

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:675: if (FcResultMatch != result) {
// just a sanity check

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:774: const char bpc47[],
/* may be NULL*/ ?

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:780: if (NULL == pattern) {
add SkASSERT(pattern) ?

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:787: SkAutoFcCharSet
charSet(FcCharSetCreate());
No null check?

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:792: SkAutoFcLangSet
langSet(FcLangSetCreate());
...

[bungeman-skia, 2014-09-09 19:06:18]

Perhaps this makes things nicer?

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
File src/ports/SkFontMgr_fontconfig.cpp (right):

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:675: if (FcResultMatch != result) {
On 2014/08/28 21:32:23, mtklein wrote:
> // just a sanity check

Acknowledged.

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:774: const char bpc47[],
On 2014/08/28 21:32:23, mtklein wrote:
> /* may be NULL*/ ?

This sort of comment needs to be over in SkFontMgr.h. I'll keep it in mind.

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:780: if (NULL == pattern) {
On 2014/08/28 21:32:23, mtklein wrote:
> add SkASSERT(pattern) ?

Done.

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:787: SkAutoFcCharSet
charSet(FcCharSetCreate());
On 2014/08/28 21:32:23, mtklein wrote:
> No null check?

Done.

https://codereview.chromium.org/489733005/diff/1/src/ports/SkFontMgr_fontconf...
src/ports/SkFontMgr_fontconfig.cpp:792: SkAutoFcLangSet
langSet(FcLangSetCreate());
On 2014/08/28 21:32:23, mtklein wrote:
> ...

Done.

[mtklein, 2014-09-09 19:08:04]

lgtm

[bungeman-skia, 2014-09-09 19:33:18]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-09-09 19:33:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/489733005/40001

[commit-bot: I haz the power, 2014-09-09 19:50:39]

Committed patchset #3 (id:40001) as 6bc2c94de334efb40e1a09e31112262dec77532b