Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 489713003: Add armv7s to the iOS ARCH list (Closed)

Created:
6 years, 3 months ago by stuartmorgan
Modified:
6 years, 3 months ago
Reviewers:
blundell
CC:
chromium-reviews, rohitrao (ping after 24h), lliabra, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add armv7s to the iOS ARCH list App Store rules require shipping armv7s with arm64, so this is required for the "both" configuration. Also adds it to the 32-bit configuration so that local testing will better match actual builds, but we can revisit if that turns out to be onerous in practice. BUG=407295 Committed: https://crrev.com/f1dc118635a18587a35b3d6f5092878467c261dd Cr-Commit-Position: refs/heads/master@{#291930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
stuartmorgan
stuartmorgan@chromium.org changed reviewers: + blundell@chromium.org
6 years, 3 months ago (2014-08-26 14:47:34 UTC) #1
stuartmorgan
6 years, 3 months ago (2014-08-26 14:47:34 UTC) #2
blundell
lgtm
6 years, 3 months ago (2014-08-26 14:49:00 UTC) #3
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 3 months ago (2014-08-26 15:25:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/489713003/1
6 years, 3 months ago (2014-08-26 15:26:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 16:30:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as a85d67257a701d61444c71b6d4d9cb5760d1e141
6 years, 3 months ago (2014-08-26 17:53:52 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1dc118635a18587a35b3d6f5092878467c261dd
Cr-Commit-Position: refs/heads/master@{#291930}

Powered by Google App Engine
This is Rietveld 408576698