Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 489643002: [refactor] Split up a large (5k lines) unit-test into multiple files. (Closed)

Created:
6 years, 4 months ago by eroman
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[refactor] Split up a large (5k lines) unit-test into multiple files. BUG=398959 Committed: https://crrev.com/751d179ac804eb0f58df23c4a55ea7cbd9780be8 Cr-Commit-Position: refs/heads/master@{#291858}

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : Fix compile error (by removing NSS ifdefed code) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2528 lines, -26635 lines) Patch
D content/child/webcrypto/shared_crypto_unittest.cc View 1 2 1 chunk +0 lines, -4858 lines 0 comments Download
A + content/child/webcrypto/test/aes_cbc_unittest.cc View 1 2 9 chunks +85 lines, -3902 lines 0 comments Download
A content/child/webcrypto/test/aes_gcm_unittest.cc View 1 2 1 chunk +270 lines, -0 lines 0 comments Download
A + content/child/webcrypto/test/aes_kw_unittest.cc View 1 2 2 chunks +346 lines, -4597 lines 0 comments Download
A content/child/webcrypto/test/hmac_unittest.cc View 1 2 1 chunk +530 lines, -0 lines 0 comments Download
A + content/child/webcrypto/test/rsa_oaep_unittest.cc View 1 2 2 chunks +72 lines, -4288 lines 0 comments Download
A + content/child/webcrypto/test/rsa_ssa_unittest.cc View 1 2 4 chunks +866 lines, -4515 lines 0 comments Download
A + content/child/webcrypto/test/sha_unittest.cc View 1 2 2 chunks +59 lines, -61 lines 0 comments Download
A + content/child/webcrypto/test/status_unittest.cc View 1 2 2 chunks +55 lines, -65 lines 0 comments Download
A content/child/webcrypto/test/test_helpers.h View 1 2 1 chunk +179 lines, -0 lines 0 comments Download
A + content/child/webcrypto/test/test_helpers.cc View 1 2 14 chunks +56 lines, -4348 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
eroman
6 years, 4 months ago (2014-08-19 21:40:10 UTC) #1
Ryan Sleevi
This is impossible to effectively review. To the extent you're not introducing any backdoors to ...
6 years, 4 months ago (2014-08-25 06:14:19 UTC) #2
eroman
Correct, everything should be moves unless there were errors on my part.
6 years, 4 months ago (2014-08-25 23:03:27 UTC) #3
eroman
One thing I did to verify was run the tests before and after, and make ...
6 years, 4 months ago (2014-08-25 23:04:54 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 4 months ago (2014-08-25 23:50:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/489643002/50001
6 years, 4 months ago (2014-08-25 23:53:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-26 01:46:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:54:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/7782)
6 years, 4 months ago (2014-08-26 01:54:50 UTC) #9
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 4 months ago (2014-08-26 04:02:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/489643002/60001
6 years, 4 months ago (2014-08-26 04:03:51 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (60001) as 52d78f57d52200e181a87e79371202c2910657a1
6 years, 3 months ago (2014-08-26 06:57:30 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:06 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/751d179ac804eb0f58df23c4a55ea7cbd9780be8
Cr-Commit-Position: refs/heads/master@{#291858}

Powered by Google App Engine
This is Rietveld 408576698