Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 489633002: Move 'debugger' from child to browser (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Move 'debugger' from child to browser 'debugger' only references browser code, so I think this was always in the wrong place (probably my mistake from a while back when we split the DLLs). There are other places where browser depends on debugger already. R=sky@chromium.org BUG=404809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 4 months ago (2014-08-19 21:42:16 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-19 21:50:20 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-19 22:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/489633002/1
6 years, 4 months ago (2014-08-19 22:02:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-19 23:10:09 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 00:21:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290711

Powered by Google App Engine
This is Rietveld 408576698