Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489593005: Upload pdf.dll symbols to chromium symbol server. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Ryan Sleevi
Project:
chromium
Visibility:
Public.

Description

Upload pdf.dll symbols to chromium symbol server. BUG=405223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290690

Patch Set 1 : Tue 08/19/2014 13:37:51.39 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-19 20:39:37 UTC) #1
kerz_google
These are the open source pdf symbols correct? If so, LGTM.
6 years, 4 months ago (2014-08-19 20:45:08 UTC) #2
Vitaly Buka (NO REVIEWS)
+jam, just in case. PDF.dll is build from open source code, so there is no ...
6 years, 4 months ago (2014-08-19 20:48:54 UTC) #3
Ryan Sleevi
Not qualified to review. I leave it to jam/those familiar with how pdf.dll is built. ...
6 years, 4 months ago (2014-08-19 21:40:42 UTC) #4
jam
lgtm no need to wait for m36
6 years, 4 months ago (2014-08-19 21:51:11 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-19 21:53:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/489593005/20001
6 years, 4 months ago (2014-08-19 21:56:33 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 23:19:15 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (20001) as 290690

Powered by Google App Engine
This is Rietveld 408576698