Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: test/cctest/compiler/test-run-jscalls.cc

Issue 489543002: Revert "Load global object and builtins from activation." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-jscalls.cc
diff --git a/test/cctest/compiler/test-run-jscalls.cc b/test/cctest/compiler/test-run-jscalls.cc
index a29bde3a5d08f1c57ee183508034c0ceb5608743..fa7e98d5ec8178940dcb901c0f29f71115453f14 100644
--- a/test/cctest/compiler/test-run-jscalls.cc
+++ b/test/cctest/compiler/test-run-jscalls.cc
@@ -245,88 +245,3 @@ TEST(CallEval) {
T.CheckCall(T.Val(42), T.Val("x"), T.undefined());
}
-
-#if V8_TURBOFAN_TARGET
-
-TEST(ContextLoadedFromActivation) {
- i::FLAG_turbo_filter = "*";
- i::FLAG_always_opt = true;
- i::FLAG_context_specialization = false;
-
- const char* script =
- "var x = 42;"
- "(function() {"
- " return function () { return x };"
- "})()";
-
- v8::Isolate* isolate = CcTest::isolate();
- v8::HandleScope outer(isolate);
- v8::Local<v8::Value> fun;
- {
- v8::Local<v8::Context> env = v8::Context::New(isolate);
- env->Enter();
- CompileRun("var x = 42;");
- fun = CompileRun(script);
- env->Global()->Set(v8_str("foo"), fun);
- ExpectInt32("foo();", 42);
- env->Exit();
- }
-
- {
- v8::Local<v8::Context> env = v8::Context::New(isolate);
- env->Enter();
- v8::Local<v8::Value> fun2 = CompileRun(script);
- i::Handle<i::Object> oifun = v8::Utils::OpenHandle(*fun);
- i::Handle<i::JSFunction> ifun = Handle<JSFunction>::cast(oifun);
- i::Handle<i::Object> oifun2 = v8::Utils::OpenHandle(*fun2);
- i::Handle<i::JSFunction> ifun2 = Handle<JSFunction>::cast(oifun2);
- ifun2->set_code(ifun->code());
- env->Global()->Set(v8_str("foo"), fun2);
- CompileRun("var x = 24;");
- ExpectInt32("foo();", 24);
- env->Exit();
- }
-}
-
-
-TEST(BuiltinLoadedFromActivation) {
- i::FLAG_turbo_filter = "*";
- i::FLAG_always_opt = true;
- i::FLAG_context_specialization = false;
-
- const char* script =
- "var x = 42;"
- "(function() {"
- " return function () { return this; };"
- "})()";
-
- v8::Isolate* isolate = CcTest::isolate();
- v8::HandleScope outer(isolate);
- v8::Local<v8::Value> fun;
- {
- v8::Local<v8::Context> env = v8::Context::New(isolate);
- env->Enter();
- CompileRun("var x = 42;");
- fun = CompileRun(script);
- env->Global()->Set(v8_str("foo"), fun);
- ExpectObject("foo()", env->Global());
- env->Exit();
- }
-
- {
- v8::Local<v8::Context> env = v8::Context::New(isolate);
- env->Enter();
- v8::Local<v8::Value> fun2 = CompileRun(script);
- i::Handle<i::Object> oifun = v8::Utils::OpenHandle(*fun);
- i::Handle<i::JSFunction> ifun = Handle<JSFunction>::cast(oifun);
- i::Handle<i::Object> oifun2 = v8::Utils::OpenHandle(*fun2);
- i::Handle<i::JSFunction> ifun2 = Handle<JSFunction>::cast(oifun2);
- ifun2->set_code(ifun->code());
- env->Global()->Set(v8_str("foo"), fun2);
- CompileRun("var x = 24;");
- ExpectObject("foo()", env->Global());
- env->Exit();
- }
-}
-
-#endif // V8_TURBO_TARGET
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698