Issue 489543002: Revert "Load global object and builtins from activation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 489543002: Revert "Load global object and builtins from activation." (Closed)

Created:
6 years, 4 months ago by sigurds

Modified:
6 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Load global object and builtins from activation." This reverts commit r23205. Setting string-type flags in unit tests is not a good idea. TBR=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23208

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -117 lines)			Patch
M	src/compiler/ast-graph-builder.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View	6 chunks	+25 lines, -31 lines	0 comments	Download
M	test/cctest/compiler/test-run-jscalls.cc	View	1 chunk	+0 lines, -85 lines	0 comments	Download

Total messages: 1 (0 generated)

sigurds

6 years, 4 months ago (2014-08-19 16:07:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as 23208 (tree was closed).