Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 48953004: Enable global command test on Linux Aura. (Closed)

Created:
7 years, 1 month ago by zhchbin
Modified:
7 years, 1 month ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable global command test on Linux Aura. BUG=302437 TEST=interactive_ui_tests --gtest_filter=GlobalCommandsApiTest.GlobalCommand Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233217

Patch Set 1 #

Patch Set 2 : nit. #

Patch Set 3 : Disable on linux_chrome_os #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/extensions/extension_commands_global_registry_apitest.cc View 1 2 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zhchbin
@finnur, please review.
7 years, 1 month ago (2013-11-01 09:51:53 UTC) #1
Finnur
LGTM
7 years, 1 month ago (2013-11-05 10:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/48953004/30001
7 years, 1 month ago (2013-11-05 10:23:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=171818
7 years, 1 month ago (2013-11-05 11:55:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/48953004/300001
7 years, 1 month ago (2013-11-05 12:19:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97887
7 years, 1 month ago (2013-11-05 15:02:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/48953004/300001
7 years, 1 month ago (2013-11-06 00:26:05 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 05:16:52 UTC) #8
Message was sent while issue was closed. 
Change committed as 233217

Powered by Google App Engine
This is Rietveld 408576698