Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 489493004: Update view manager to support content handling. (Closed)

Created:
6 years, 4 months ago by Aaron Boodman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update view manager to support content handling. Change demo launcher to use this instead of Navigator interface. Update existing apps and remove Navigator interface. BUG=

Patch Set 1 #

Patch Set 2 : png viewer works sorta #

Total comments: 2

Patch Set 3 : getting closer #

Patch Set 4 : blah #

Patch Set 5 : html viewer compiles again as a content handler #

Patch Set 6 : blah to the blizzah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -555 lines) Patch
M mojo/application_manager/application_loader.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/application_manager/application_loader.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M mojo/application_manager/application_manager.h View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/application_manager/application_manager.cc View 1 2 3 3 chunks +18 lines, -5 lines 0 comments Download
M mojo/examples/content_handler_demo/content_handler_demo.cc View 1 2 3 2 chunks +9 lines, -7 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 1 2 5 chunks +8 lines, -60 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 1 2 5 chunks +1 line, -53 lines 0 comments Download
M mojo/examples/png_viewer/png_viewer.cc View 1 2 3 5 chunks +133 lines, -130 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 1 2 7 chunks +10 lines, -43 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/application/interface_factory_impl.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/lib/service_provider_impl.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 1 2 3 4 5 4 chunks +36 lines, -7 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 2 3 4 5 4 chunks +29 lines, -12 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 1 2 3 4 5 1 chunk +30 lines, -65 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 2 1 chunk +18 lines, -26 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 3 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/dynamic_application_loader.h View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/dynamic_application_loader.cc View 1 2 3 3 chunks +131 lines, -99 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
https://codereview.chromium.org/489493004/diff/20001/mojo/examples/png_viewer/png_viewer.cc File mojo/examples/png_viewer/png_viewer.cc (right): https://codereview.chromium.org/489493004/diff/20001/mojo/examples/png_viewer/png_viewer.cc#newcode226 mojo/examples/png_viewer/png_viewer.cc:226: ServiceProviderPtr service_provider) OVERRIDE { We probably want to change ...
6 years, 4 months ago (2014-08-20 05:16:49 UTC) #1
Aaron Boodman
6 years, 4 months ago (2014-08-20 06:21:03 UTC) #2
https://codereview.chromium.org/489493004/diff/20001/mojo/examples/png_viewer...
File mojo/examples/png_viewer/png_viewer.cc (right):

https://codereview.chromium.org/489493004/diff/20001/mojo/examples/png_viewer...
mojo/examples/png_viewer/png_viewer.cc:226: ServiceProviderPtr service_provider)
OVERRIDE {
On 2014/08/20 05:16:49, darin wrote:
> We probably want to change ContentHandler to take an
> InterfaceRequest<ServiceProvider> instead (i.e., "ServiceProvider&" in the
mojom
> file). That way you can use BindToRequest to bind the lifetime of the PNGView
to
> the pipe. It also means that both sides have to implement
> InterfaceImpl<ServiceProvider>, which makes things more symmetric. This is how
> Embed / OnEmbed work. It is quite nice. See also
> mojo/public/cpp/application/service_provider_impl.h. Ben added that to make it
> easier to implement ServiceProvider.

Does the BindToPipe() call I'm using in PNGView not do the same thing wrt
lifetimes?

Powered by Google App Engine
This is Rietveld 408576698