Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 489493002: Add kOsMac to the enable-password-generation supported platforms. (Closed)

Created:
6 years, 4 months ago by dconnelly
Modified:
6 years, 4 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add kOsMac to the enable-password-generation supported platforms. BUG=394303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291455

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 16 (0 generated)
dconnelly
6 years, 4 months ago (2014-08-19 13:38:51 UTC) #1
Garrett Casto
LGTM, though obviously you should wait until https://codereview.chromium.org/487193003/ lands to submit htis. https://codereview.chromium.org/489493002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc ...
6 years, 4 months ago (2014-08-20 22:48:14 UTC) #2
dconnelly
The CQ bit was checked by dconnelly@chromium.org
6 years, 4 months ago (2014-08-22 12:55:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/489493002/1
6 years, 4 months ago (2014-08-22 12:56:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 14:01:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 14:55:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1423)
6 years, 4 months ago (2014-08-22 14:55:26 UTC) #7
dconnelly
The CQ bit was checked by dconnelly@chromium.org
6 years, 4 months ago (2014-08-22 15:03:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/489493002/1
6 years, 4 months ago (2014-08-22 15:03:43 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 15:59:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 16:45:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1454)
6 years, 4 months ago (2014-08-22 16:45:48 UTC) #12
dconnelly
The CQ bit was checked by dconnelly@chromium.org
6 years, 4 months ago (2014-08-22 16:50:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/489493002/1
6 years, 4 months ago (2014-08-22 16:51:14 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 17:40:01 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 18:35:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (1) as 291455

Powered by Google App Engine
This is Rietveld 408576698