Chromium Code Reviews

Issue 489473002: refer to WebServiceWorkerCacheError values in c++03 style (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
Reviewers:
falken, gavinp
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

refer to WebServiceWorkerCacheError values in c++03 style Since WebServiceWorkerCacheError values are prefixed with "WebServiceWorkerCacheError", the c++11 style enum prefix is a bit redundant. BUG=392621 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180548

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -3 lines)
M Source/modules/serviceworkers/CacheStorage.cpp View 1 chunk +3 lines, -3 lines 0 comments

Messages

Total messages: 5 (0 generated)
Mostyn Bramley-Moore
@falken, gavinp: Please take a look.
6 years, 4 months ago (2014-08-19 10:54:27 UTC) #1
falken
lgtm
6 years, 4 months ago (2014-08-19 11:12:02 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-19 11:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/489473002/1
6 years, 4 months ago (2014-08-19 11:14:04 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 12:17:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180548

Powered by Google App Engine