Issue 489453002: Add GetAppDefaultIcon() to AppDelegate

Issue 489453002: Add GetAppDefaultIcon() to AppDelegate (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 4 months ago

Reviewers:
benwells

CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add GetAppDefaultIcon() to AppDelegate To avoid including theme_resources.h in app_window.cc BUG=403726 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290769

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
M	apps/app_delegate.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	apps/app_window.cc	View	1	3 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ui/apps/chrome_app_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/apps/chrome_app_delegate.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/489453002/20001

6 years, 4 months ago (2014-08-20 04:20:16 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (20001) as 290769

6 years, 4 months ago (2014-08-20 05:19:25 UTC) #5

aarya

On 2014/08/20 05:19:25, I haz the power (commit-bot) wrote: > Committed patchset #2 (20001) as ...

6 years, 4 months ago (2014-08-20 05:21:58 UTC) #6

hashimoto

6 years, 4 months ago (2014-08-20 05:24:16 UTC) #7

Message was sent while issue was closed.

On 2014/08/20 05:21:58, aarya wrote:
> On 2014/08/20 05:19:25, I haz the power (commit-bot) wrote:
> > Committed patchset #2 (20001) as 290769
> 
> hashimoto@, please fix bug number in your codereview, you are updating
> incorrectly a security bug twice.

Oops, the correct number was 403726.
Sorry.

Expand Messages | Collapse Messages